fix up midi stuff w/music mode
Don't "unselect" left-hand rows
"unselecting" left-hand rows is a wasted i2c transaction.
On the left-hand side, the ergodox uses a GPIO expander. It
does *not* change "direction" (input/output) of pins, it just
sets pins high or low.
But all the pins are written at once. There's no way to
change just one pin's value; you send a full byte of all eight
row pins. (Not all of them are in use, but that doesn't matter.)
So every pin is either +V or ground. This is in contrast
with the right-hand side, which is using input mode to make pins
be neutral.
So there's no need to "deselect" the rows on the left side
at all. To select row 0, you set the GPIO register for the
rows to 0xFE. The previous code would then set it back to
0xFF, then set it to 0xFD on the next cycle. But we can just
omit the intervening step, and set it to 0xFD next cycle,
and get the same results.
And yes, I tested that the keyboard still works.
On my system, scan rate as reported by DEBUG_SCAN_RATE goes
from 445 or so to 579 or so, thus, from ~2.24ms to ~1.73ms.
Signed-off-by: seebs <seebs@seebs.net>
change the ?= assignments to =
some planck keymap shiftings and include proper-making
clean up bananasplit keymap
Fix some of the more obvious typos
Convert all headings to Title Case
New Planck Layout (#2123)
* added own keymap for planck
* Update Readme.md
* Update Readme.md
* Update Readme.md
* Update Readme.md
* Update Readme.md
Turn on prevent stuck modifiers for my keymaps.
Updated copyright headers and peer review fixes
Add support for LFKeyboard products: LFK78, LFK87 and SMK65
fix link for grave escape in docs
Updated color for base layer to better match my key caps (Dasher)
Pointing to the right build URL
The previous URI used to point to the Nyquist keyboard build guide.