~ruther/qmk_firmware: Fix LED configuration for PS2AVRGB boards (#7989)

38 files changed, 71 insertions(+), 102 deletions(-)

M keyboards/ares/ares.c
M keyboards/ares/config.h
M keyboards/bfake/bfake.c
M keyboards/bfake/config.h
M keyboards/db/db63/config.h
M keyboards/donutcables/budget96/budget96.c
M keyboards/donutcables/budget96/config.h
M keyboards/eve/meteor/meteor.c
M keyboards/exclusive/e6v2/le_bmc/le_bmc.c
M keyboards/exclusive/e6v2/oe_bmc/oe_bmc.c
M keyboards/exent/config.h
M keyboards/exent/exent.c
M keyboards/facew/config.h
M keyboards/facew/facew.c
M keyboards/ft/mars80/config.h
M keyboards/ft/mars80/mars80.c
M keyboards/gray_studio/hb85/config.h
M keyboards/gray_studio/hb85/hb85.c
M keyboards/j80/j80.c
M keyboards/jc65/v32a/v32a.c
M keyboards/kbdfans/kbdpad/mk1/mk1.c
M keyboards/mehkee96/mehkee96.c
M keyboards/panc60/panc60.c
M keyboards/pearl/pearl.c
M keyboards/percent/canoe/canoe.c
M keyboards/percent/skog/skog.c
M keyboards/percent/skog_lite/skog_lite.c
M keyboards/singa/singa.c
M keyboards/tgr/alice/alice.c
M keyboards/tgr/jane/jane.c
M keyboards/unikorn/unikorn.c
M keyboards/winkeyless/bface/bface.c
M keyboards/winkeyless/bmini/bmini.c
M keyboards/winkeyless/bminiex/bminiex.c
M keyboards/ymd75/ymd75.c
M keyboards/ymd96/ymd96.c
M keyboards/ymdk/bface/bface.c
M keyboards/ymdk_np21/ymdk_np21.c

M keyboards/ares/ares.c => keyboards/ares/ares.c +1 -2

@@ 24,12 24,11 @@ void keyboard_pre_init_kb(void) {
 
 void led_init_ports(void) {
     setPinOutput(D1);
-    writePinHigh(D1);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D1, !led_state.caps_lock);
+        writePin(D1, led_state.caps_lock);
     }
     return true;
 }

M keyboards/ares/config.h => keyboards/ares/config.h +1 -0

@@ 39,6 39,7 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 #define BACKLIGHT_PIN D4
 #define BACKLIGHT_LEVELS 3
+
 #define RGBLIGHT_ANIMATIONS
 
 #define NO_UART 1

M keyboards/bfake/bfake.c => keyboards/bfake/bfake.c +1 -2

@@ 24,12 24,11 @@ void keyboard_pre_init_kb(void) {
 
 void led_init_ports(void) {
     setPinOutput(D1);
-    writePinHigh(D1);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D1, !led_state.caps_lock);
+        writePin(D1, led_state.caps_lock);
     }
     return true;
 }

M keyboards/bfake/config.h => keyboards/bfake/config.h +1 -0

@@ 39,6 39,7 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 #define BACKLIGHT_PIN D4
 #define BACKLIGHT_LEVELS 3
+
 #define RGBLIGHT_ANIMATIONS
 
 #define NO_UART 1

M keyboards/db/db63/config.h => keyboards/db/db63/config.h +0 -1

@@ 41,4 41,3 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 #define BACKLIGHT_PIN D4
 #define BACKLIGHT_LEVELS 3
-

M keyboards/donutcables/budget96/budget96.c => keyboards/donutcables/budget96/budget96.c +2 -4

@@ 24,14 24,12 @@ void keyboard_pre_init_kb(void) {
 void led_init_ports(void) {
     setPinOutput(D0);
     setPinOutput(D1);
-    writePinHigh(D0);
-    writePinHigh(D1);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D0, !led_state.num_lock);
-        writePin(D1, !led_state.caps_lock);
+        writePin(D0, led_state.num_lock);
+        writePin(D1, led_state.caps_lock);
     }
     return true;
 }

M keyboards/donutcables/budget96/config.h => keyboards/donutcables/budget96/config.h +1 -0

@@ 39,4 39,5 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 #define BACKLIGHT_PIN D4
 #define BACKLIGHT_LEVELS 3
+
 #define RGBLIGHT_ANIMATIONS

M keyboards/eve/meteor/meteor.c => keyboards/eve/meteor/meteor.c +1 -2

@@ 23,12 23,11 @@ void keyboard_pre_init_kb(void) {
 
 void led_init_ports(void) {
     setPinOutput(D1);
-    writePinHigh(D1);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D1, !led_state.caps_lock);
+        writePin(D1, led_state.caps_lock);
     }
     return true;
 }

M keyboards/exclusive/e6v2/le_bmc/le_bmc.c => keyboards/exclusive/e6v2/le_bmc/le_bmc.c +1 -2

@@ 23,12 23,11 @@ void keyboard_pre_init_kb(void) {
 
 void led_init_ports(void) {
     setPinOutput(D1);
-    writePinHigh(D1);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D1, !led_state.caps_lock);
+        writePin(D1, led_state.caps_lock);
     }
     return true;
 }

M keyboards/exclusive/e6v2/oe_bmc/oe_bmc.c => keyboards/exclusive/e6v2/oe_bmc/oe_bmc.c +1 -2

@@ 23,12 23,11 @@ void keyboard_pre_init_kb(void) {
 
 void led_init_ports(void) {
     setPinOutput(D1);
-    writePinHigh(D1);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D1, !led_state.caps_lock);
+        writePin(D1, led_state.caps_lock);
     }
     return true;
 }

M keyboards/exent/config.h => keyboards/exent/config.h +1 -0

@@ 41,6 41,7 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 #define BACKLIGHT_PIN D4
 #define BACKLIGHT_LEVELS 3
+
 #define RGBLIGHT_ANIMATIONS
 
 #define NO_UART 1

M keyboards/exent/exent.c => keyboards/exent/exent.c +3 -6

@@ 25,16 25,13 @@ void led_init_ports(void) {
     setPinOutput(D0);
     setPinOutput(D1);
     setPinOutput(D6);
-    writePinHigh(D0);
-    writePinHigh(D1);
-    writePinHigh(D6);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D0, !led_state.num_lock);
-        writePin(D1, !led_state.caps_lock);
-        writePin(D6, !led_state.scroll_lock);
+        writePin(D0, led_state.num_lock);
+        writePin(D1, led_state.caps_lock);
+        writePin(D6, led_state.scroll_lock);
     }
     return true;
 }

M keyboards/facew/config.h => keyboards/facew/config.h +1 -0

@@ 39,4 39,5 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 #define BACKLIGHT_PIN D4
 #define BACKLIGHT_LEVELS 3
+
 #define RGBLIGHT_ANIMATIONS

M keyboards/facew/facew.c => keyboards/facew/facew.c +2 -3

@@ 25,13 25,12 @@ void keyboard_pre_init_kb(void) {
 void led_init_ports(void) {
     setPinOutput(D0);
     setPinOutput(D1);
-    writePinHigh(D0);
-    writePinHigh(D1);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D1, !led_state.caps_lock);
+        writePin(D0, led_state.num_lock);
+        writePin(D1, led_state.caps_lock);
     }
     return true;
 }

M keyboards/ft/mars80/config.h => keyboards/ft/mars80/config.h +1 -0

@@ 40,6 40,7 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 #define BACKLIGHT_PIN D4
 #define BACKLIGHT_LEVELS 3
+
 #define RGBLIGHT_ANIMATIONS
 
 #define NO_UART 1

M keyboards/ft/mars80/mars80.c => keyboards/ft/mars80/mars80.c +2 -4

@@ 24,14 24,12 @@ void keyboard_pre_init_kb(void) {
 void led_init_ports(void) {
     setPinOutput(D1);
     setPinOutput(D6);
-    writePinHigh(D1);
-    writePinHigh(D6);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D1, !led_state.caps_lock);
-        writePin(D6, !led_state.scroll_lock);
+        writePin(D1, led_state.caps_lock);
+        writePin(D6, led_state.scroll_lock);
     }
     return true;
 }

M keyboards/gray_studio/hb85/config.h => keyboards/gray_studio/hb85/config.h +3 -0

@@ 33,3 33,6 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 #define RGBLED_NUM 5
 #define RGBLIGHT_ANIMATIONS
+
+#define BACKLIGHT_PIN D4
+#define BACKLIGHT_LEVELS 3

M keyboards/gray_studio/hb85/hb85.c => keyboards/gray_studio/hb85/hb85.c +3 -6

@@ 27,16 27,13 @@ void led_init_ports(void) {
     setPinOutput(D0);
     setPinOutput(D1);
     setPinOutput(D6);
-    writePinHigh(D0);
-    writePinHigh(D1);
-    writePinHigh(D6);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D0, !led_state.num_lock);
-        writePin(D1, !led_state.caps_lock);
-        writePin(D6, !led_state.scroll_lock);
+        writePin(D0, led_state.num_lock);
+        writePin(D1, led_state.caps_lock);
+        writePin(D6, led_state.scroll_lock);
     }
     return true;
 }

M keyboards/j80/j80.c => keyboards/j80/j80.c +12 -1

@@ 16,10 16,21 @@
 
 #include "j80.h"
 
+void keyboard_pre_init_kb(void) {
+    led_init_ports();
+    keyboard_pre_init_user();
+}
+
+void led_init_ports(void) {
+    setPinOutput(D0);
+    setPinOutput(D1);
+    setPinOutput(D6);
+}
+
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D1, led_state.caps_lock);
         writePin(D0, led_state.num_lock);
+        writePin(D1, led_state.caps_lock);
         writePin(D6, led_state.scroll_lock);
     }
     return true;

M keyboards/jc65/v32a/v32a.c => keyboards/jc65/v32a/v32a.c +1 -2

@@ 24,12 24,11 @@ void keyboard_pre_init_kb(void) {
 
 void led_init_ports(void) {
     setPinOutput(D1);
-    writePinHigh(D1);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D1, !led_state.caps_lock);
+        writePin(D1, led_state.caps_lock);
     }
     return true;
 }

M keyboards/kbdfans/kbdpad/mk1/mk1.c => keyboards/kbdfans/kbdpad/mk1/mk1.c +1 -2

@@ 23,12 23,11 @@ void keyboard_pre_init_kb(void) {
 
 void led_init_ports(void) {
     setPinOutput(D0);
-    writePinHigh(D0);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D0, !led_state.num_lock);
+        writePin(D0, led_state.num_lock);
     }
     return true;
 }

M keyboards/mehkee96/mehkee96.c => keyboards/mehkee96/mehkee96.c +2 -4

@@ 25,14 25,12 @@ void keyboard_pre_init_kb(void) {
 void led_init_ports(void) {
     setPinOutput(D0);
     setPinOutput(D1);
-    writePinHigh(D0);
-    writePinHigh(D1);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D0, !led_state.num_lock);
-        writePin(D1, !led_state.caps_lock);
+        writePin(D0, led_state.num_lock);
+        writePin(D1, led_state.caps_lock);
     }
     return true;
 }

M keyboards/panc60/panc60.c => keyboards/panc60/panc60.c +1 -2

@@ 23,12 23,11 @@ void keyboard_pre_init_kb(void) {
 
 void led_init_ports(void) {
     setPinOutput(D1);
-    writePinHigh(D1);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D1, !led_state.caps_lock);
+        writePin(D1, led_state.caps_lock);
     }
     return true;
 }

M keyboards/pearl/pearl.c => keyboards/pearl/pearl.c +3 -6

@@ 26,16 26,13 @@ void led_init_ports(void) {
     setPinOutput(D0);
     setPinOutput(D1);
     setPinOutput(D6);
-    writePinHigh(D0);
-    writePinHigh(D1);
-    writePinHigh(D6);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D0, !led_state.num_lock);
-        writePin(D1, !led_state.caps_lock);
-        writePin(D6, !led_state.scroll_lock);
+        writePin(D0, led_state.num_lock);
+        writePin(D1, led_state.caps_lock);
+        writePin(D6, led_state.scroll_lock);
     }
     return true;
 }

M keyboards/percent/canoe/canoe.c => keyboards/percent/canoe/canoe.c +1 -2

@@ 24,12 24,11 @@ void keyboard_pre_init_kb(void) {
 
 void led_init_ports(void) {
     setPinOutput(D1);
-    writePinHigh(D1);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D1, !led_state.caps_lock);
+        writePin(D1, led_state.caps_lock);
     }
     return true;
 }

M keyboards/percent/skog/skog.c => keyboards/percent/skog/skog.c +2 -4

@@ 27,14 27,12 @@ void keyboard_pre_init_kb(void) {
 void led_init_ports(void) {
     setPinOutput(D1);
     setPinOutput(D6);
-    writePinHigh(D1);
-    writePinHigh(D6);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D1, !led_state.caps_lock);
-        writePin(D6, !led_state.scroll_lock);
+        writePin(D1, led_state.caps_lock);
+        writePin(D6, led_state.scroll_lock);
     }
     return true;
 }

M keyboards/percent/skog_lite/skog_lite.c => keyboards/percent/skog_lite/skog_lite.c +2 -4

@@ 24,14 24,12 @@ void keyboard_pre_init_kb(void) {
 void led_init_ports(void) {
     setPinOutput(D1);
     setPinOutput(D6);
-    writePinHigh(D1);
-    writePinHigh(D6);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D1, !led_state.caps_lock);
-        writePin(D6, !led_state.scroll_lock);
+        writePin(D1, led_state.caps_lock);
+        writePin(D6, led_state.scroll_lock);
     }
     return true;
 }

M keyboards/singa/singa.c => keyboards/singa/singa.c +1 -2

@@ 23,12 23,11 @@ void keyboard_pre_init_kb(void) {
 
 void led_init_ports(void) {
     setPinOutput(D1);
-    writePinHigh(D1);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D1, !led_state.caps_lock);
+        writePin(D1, led_state.caps_lock);
     }
     return true;
 }

M keyboards/tgr/alice/alice.c => keyboards/tgr/alice/alice.c +3 -6

@@ 26,16 26,13 @@ void led_init_ports(void) {
     setPinOutput(D0);
     setPinOutput(D1);
     setPinOutput(D6);
-    writePinHigh(D0);
-    writePinHigh(D1);
-    writePinHigh(D6);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D0, !led_state.num_lock);
-        writePin(D1, !led_state.caps_lock);
-        writePin(D6, !led_state.scroll_lock);
+        writePin(D0, led_state.num_lock);
+        writePin(D1, led_state.caps_lock);
+        writePin(D6, led_state.scroll_lock);
     }
     return true;
 }

M keyboards/tgr/jane/jane.c => keyboards/tgr/jane/jane.c +2 -4

@@ 24,14 24,12 @@ void keyboard_pre_init_kb(void) {
 void led_init_ports(void) {
     setPinOutput(D1);
     setPinOutput(D6);
-    writePinHigh(D1);
-    writePinHigh(D6);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D1, !led_state.caps_lock);
-        writePin(D6, !led_state.scroll_lock);
+        writePin(D1, led_state.caps_lock);
+        writePin(D6, led_state.scroll_lock);
     }
     return true;
 }

M keyboards/unikorn/unikorn.c => keyboards/unikorn/unikorn.c +1 -2

@@ 23,12 23,11 @@ void keyboard_pre_init_kb(void) {
 
 void led_init_ports(void) {
     setPinOutput(D1);
-    writePinHigh(D1);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D1, !led_state.caps_lock);
+        writePin(D1, led_state.caps_lock);
     }
     return true;
 }

M keyboards/winkeyless/bface/bface.c => keyboards/winkeyless/bface/bface.c +3 -6

@@ 25,16 25,13 @@ void led_init_ports(void) {
     setPinOutput(D0);
     setPinOutput(D1);
     setPinOutput(D6);
-    writePinHigh(D0);
-    writePinHigh(D1);
-    writePinHigh(D6);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D0, !led_state.num_lock);
-        writePin(D1, !led_state.caps_lock);
-        writePin(D6, !led_state.scroll_lock);
+        writePin(D0, led_state.num_lock);
+        writePin(D1, led_state.caps_lock);
+        writePin(D6, led_state.scroll_lock);
     }
     return true;
 }

M keyboards/winkeyless/bmini/bmini.c => keyboards/winkeyless/bmini/bmini.c +3 -6

@@ 26,16 26,13 @@ void led_init_ports(void) {
     setPinOutput(D0);
     setPinOutput(D1);
     setPinOutput(D6);
-    writePinHigh(D0);
-    writePinHigh(D1);
-    writePinHigh(D6);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D0, !led_state.num_lock);
-        writePin(D1, !led_state.caps_lock);
-        writePin(D6, !led_state.scroll_lock);
+        writePin(D0, led_state.num_lock);
+        writePin(D1, led_state.caps_lock);
+        writePin(D6, led_state.scroll_lock);
     }
     return true;
 }

M keyboards/winkeyless/bminiex/bminiex.c => keyboards/winkeyless/bminiex/bminiex.c +3 -6

@@ 26,16 26,13 @@ void led_init_ports(void) {
     setPinOutput(D0);
     setPinOutput(D1);
     setPinOutput(D6);
-    writePinHigh(D0);
-    writePinHigh(D1);
-    writePinHigh(D6);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D0, !led_state.num_lock);
-        writePin(D1, !led_state.caps_lock);
-        writePin(D6, !led_state.scroll_lock);
+        writePin(D0, led_state.num_lock);
+        writePin(D1, led_state.caps_lock);
+        writePin(D6, led_state.scroll_lock);
     }
     return true;
 }

M keyboards/ymd75/ymd75.c => keyboards/ymd75/ymd75.c +1 -2

@@ 24,12 24,11 @@ void keyboard_pre_init_kb(void) {
 
 void led_init_ports(void) {
     setPinOutput(D1);
-    writePinHigh(D1);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D1, !led_state.caps_lock);
+        writePin(D1, led_state.caps_lock);
     }
     return true;
 }

M keyboards/ymd96/ymd96.c => keyboards/ymd96/ymd96.c +2 -4

@@ 26,14 26,12 @@ void keyboard_pre_init_kb(void) {
 void led_init_ports(void) {
     setPinOutput(D0);
     setPinOutput(D1);
-    writePinHigh(D0);
-    writePinHigh(D1);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D0, !led_state.num_lock);
-        writePin(D1, !led_state.caps_lock);
+        writePin(D0, led_state.num_lock);
+        writePin(D1, led_state.caps_lock);
     }
     return true;
 }

M keyboards/ymdk/bface/bface.c => keyboards/ymdk/bface/bface.c +1 -2

@@ 23,12 23,11 @@ void keyboard_pre_init_kb(void) {
 
 void led_init_ports(void) {
     setPinOutput(D1);
-    writePinHigh(D1);
 }
 
 bool led_update_kb(led_t led_state) {
     if (led_update_user(led_state)) {
-        writePin(D1, !led_state.caps_lock);
+        writePin(D1, led_state.caps_lock);
     }
     return true;
 }

M keyboards/ymdk_np21/ymdk_np21.c => keyboards/ymdk_np21/ymdk_np21.c +0 -1

@@ 25,7 25,6 @@ void keyboard_pre_init_kb(void) {
 
 void led_init_ports(void) {
     setPinOutput(D0);
-    writePinHigh(D0);
 }
 
 bool led_update_kb(led_t led_state) {