From b56899976924043a9563c12987218abd78baf13d Mon Sep 17 00:00:00 2001 From: fauxpark Date: Fri, 24 Jan 2020 14:24:10 +1100 Subject: [PATCH] Fix LED configuration for PS2AVRGB boards (#7989) * Fix LED configuration for PS2AVRGB boards * Undo backlight on state changes --- keyboards/ares/ares.c | 3 +-- keyboards/ares/config.h | 1 + keyboards/bfake/bfake.c | 3 +-- keyboards/bfake/config.h | 1 + keyboards/db/db63/config.h | 1 - keyboards/donutcables/budget96/budget96.c | 6 ++---- keyboards/donutcables/budget96/config.h | 1 + keyboards/eve/meteor/meteor.c | 3 +-- keyboards/exclusive/e6v2/le_bmc/le_bmc.c | 3 +-- keyboards/exclusive/e6v2/oe_bmc/oe_bmc.c | 3 +-- keyboards/exent/config.h | 1 + keyboards/exent/exent.c | 9 +++------ keyboards/facew/config.h | 1 + keyboards/facew/facew.c | 5 ++--- keyboards/ft/mars80/config.h | 1 + keyboards/ft/mars80/mars80.c | 6 ++---- keyboards/gray_studio/hb85/config.h | 3 +++ keyboards/gray_studio/hb85/hb85.c | 9 +++------ keyboards/j80/j80.c | 13 ++++++++++++- keyboards/jc65/v32a/v32a.c | 3 +-- keyboards/kbdfans/kbdpad/mk1/mk1.c | 3 +-- keyboards/mehkee96/mehkee96.c | 6 ++---- keyboards/panc60/panc60.c | 3 +-- keyboards/pearl/pearl.c | 9 +++------ keyboards/percent/canoe/canoe.c | 3 +-- keyboards/percent/skog/skog.c | 6 ++---- keyboards/percent/skog_lite/skog_lite.c | 6 ++---- keyboards/singa/singa.c | 3 +-- keyboards/tgr/alice/alice.c | 9 +++------ keyboards/tgr/jane/jane.c | 6 ++---- keyboards/unikorn/unikorn.c | 3 +-- keyboards/winkeyless/bface/bface.c | 9 +++------ keyboards/winkeyless/bmini/bmini.c | 9 +++------ keyboards/winkeyless/bminiex/bminiex.c | 9 +++------ keyboards/ymd75/ymd75.c | 3 +-- keyboards/ymd96/ymd96.c | 6 ++---- keyboards/ymdk/bface/bface.c | 3 +-- keyboards/ymdk_np21/ymdk_np21.c | 1 - 38 files changed, 71 insertions(+), 102 deletions(-) diff --git a/keyboards/ares/ares.c b/keyboards/ares/ares.c index e6379cb18da669b7422084f43b66d12782d6ada0..95d4b878f10f8529ebdc7dfd2839bb1fd51ad3dd 100644 --- a/keyboards/ares/ares.c +++ b/keyboards/ares/ares.c @@ -24,12 +24,11 @@ void keyboard_pre_init_kb(void) { void led_init_ports(void) { setPinOutput(D1); - writePinHigh(D1); } bool led_update_kb(led_t led_state) { if (led_update_user(led_state)) { - writePin(D1, !led_state.caps_lock); + writePin(D1, led_state.caps_lock); } return true; } diff --git a/keyboards/ares/config.h b/keyboards/ares/config.h index c50587db9c49cd12a665eaebda36abd37c1575cf..e298dfc959d0a1039d13e148c9d652fbcaa6627a 100644 --- a/keyboards/ares/config.h +++ b/keyboards/ares/config.h @@ -39,6 +39,7 @@ along with this program. If not, see . #define BACKLIGHT_PIN D4 #define BACKLIGHT_LEVELS 3 + #define RGBLIGHT_ANIMATIONS #define NO_UART 1 diff --git a/keyboards/bfake/bfake.c b/keyboards/bfake/bfake.c index eb328ba8336c8c3778b4e08162d098b80ccaf559..6d0c927462bc0f3948594045a512f8d65596f520 100644 --- a/keyboards/bfake/bfake.c +++ b/keyboards/bfake/bfake.c @@ -24,12 +24,11 @@ void keyboard_pre_init_kb(void) { void led_init_ports(void) { setPinOutput(D1); - writePinHigh(D1); } bool led_update_kb(led_t led_state) { if (led_update_user(led_state)) { - writePin(D1, !led_state.caps_lock); + writePin(D1, led_state.caps_lock); } return true; } diff --git a/keyboards/bfake/config.h b/keyboards/bfake/config.h index 7c814ccc9328958cec491209769a4a5da1fe661e..ef7a866d3db95876098065a9233b84a045bebd1a 100644 --- a/keyboards/bfake/config.h +++ b/keyboards/bfake/config.h @@ -39,6 +39,7 @@ along with this program. If not, see . #define BACKLIGHT_PIN D4 #define BACKLIGHT_LEVELS 3 + #define RGBLIGHT_ANIMATIONS #define NO_UART 1 diff --git a/keyboards/db/db63/config.h b/keyboards/db/db63/config.h index 488409e3a606e147c05adae1fde1c9a0f41c0fa2..3183201c1fe67e018da77b40658bd39f250bbdc1 100644 --- a/keyboards/db/db63/config.h +++ b/keyboards/db/db63/config.h @@ -41,4 +41,3 @@ along with this program. If not, see . #define BACKLIGHT_PIN D4 #define BACKLIGHT_LEVELS 3 - diff --git a/keyboards/donutcables/budget96/budget96.c b/keyboards/donutcables/budget96/budget96.c index 7317e24e260733d84fb5fc95bcd32ac4ad7d29cc..5f3436dc6103611cf4f9d91d507da68eeda7e7bc 100644 --- a/keyboards/donutcables/budget96/budget96.c +++ b/keyboards/donutcables/budget96/budget96.c @@ -24,14 +24,12 @@ void keyboard_pre_init_kb(void) { void led_init_ports(void) { setPinOutput(D0); setPinOutput(D1); - writePinHigh(D0); - writePinHigh(D1); } bool led_update_kb(led_t led_state) { if (led_update_user(led_state)) { - writePin(D0, !led_state.num_lock); - writePin(D1, !led_state.caps_lock); + writePin(D0, led_state.num_lock); + writePin(D1, led_state.caps_lock); } return true; } diff --git a/keyboards/donutcables/budget96/config.h b/keyboards/donutcables/budget96/config.h index dddc8075b19e6189e32efb09c012245912649aca..0e05bb76f490c2a2499f08f3017baef28876d841 100644 --- a/keyboards/donutcables/budget96/config.h +++ b/keyboards/donutcables/budget96/config.h @@ -39,4 +39,5 @@ along with this program. If not, see . #define BACKLIGHT_PIN D4 #define BACKLIGHT_LEVELS 3 + #define RGBLIGHT_ANIMATIONS diff --git a/keyboards/eve/meteor/meteor.c b/keyboards/eve/meteor/meteor.c index ac1ca5d6434b44f08e79f70cbdec6cfb05284ca6..1d080b389cc2104e5bf0e1fb646ffa6a8e415504 100644 --- a/keyboards/eve/meteor/meteor.c +++ b/keyboards/eve/meteor/meteor.c @@ -23,12 +23,11 @@ void keyboard_pre_init_kb(void) { void led_init_ports(void) { setPinOutput(D1); - writePinHigh(D1); } bool led_update_kb(led_t led_state) { if (led_update_user(led_state)) { - writePin(D1, !led_state.caps_lock); + writePin(D1, led_state.caps_lock); } return true; } diff --git a/keyboards/exclusive/e6v2/le_bmc/le_bmc.c b/keyboards/exclusive/e6v2/le_bmc/le_bmc.c index b09e588795cd0556461165540e4f7a69a92bf476..df79cc5dcf8e7bf800b4c687f7d22834972d6825 100644 --- a/keyboards/exclusive/e6v2/le_bmc/le_bmc.c +++ b/keyboards/exclusive/e6v2/le_bmc/le_bmc.c @@ -23,12 +23,11 @@ void keyboard_pre_init_kb(void) { void led_init_ports(void) { setPinOutput(D1); - writePinHigh(D1); } bool led_update_kb(led_t led_state) { if (led_update_user(led_state)) { - writePin(D1, !led_state.caps_lock); + writePin(D1, led_state.caps_lock); } return true; } diff --git a/keyboards/exclusive/e6v2/oe_bmc/oe_bmc.c b/keyboards/exclusive/e6v2/oe_bmc/oe_bmc.c index a0a6c579bdd3b6aefc5c5a5a5daf9a525c7cac44..ea74d87cb1df2bdadefd846bd6120d12c6fead6d 100644 --- a/keyboards/exclusive/e6v2/oe_bmc/oe_bmc.c +++ b/keyboards/exclusive/e6v2/oe_bmc/oe_bmc.c @@ -23,12 +23,11 @@ void keyboard_pre_init_kb(void) { void led_init_ports(void) { setPinOutput(D1); - writePinHigh(D1); } bool led_update_kb(led_t led_state) { if (led_update_user(led_state)) { - writePin(D1, !led_state.caps_lock); + writePin(D1, led_state.caps_lock); } return true; } diff --git a/keyboards/exent/config.h b/keyboards/exent/config.h index 4921746c1c59b5e6417c04b9d0a0282a978c6e37..48aee2206f34a240004dc6a08916f1a1a148a4e4 100644 --- a/keyboards/exent/config.h +++ b/keyboards/exent/config.h @@ -41,6 +41,7 @@ along with this program. If not, see . #define BACKLIGHT_PIN D4 #define BACKLIGHT_LEVELS 3 + #define RGBLIGHT_ANIMATIONS #define NO_UART 1 diff --git a/keyboards/exent/exent.c b/keyboards/exent/exent.c index c6870f2c79179a8464ff960745b4e65834ae4b19..a935e9e67fa09bf2ae99a5260aa0de7da621ca79 100644 --- a/keyboards/exent/exent.c +++ b/keyboards/exent/exent.c @@ -25,16 +25,13 @@ void led_init_ports(void) { setPinOutput(D0); setPinOutput(D1); setPinOutput(D6); - writePinHigh(D0); - writePinHigh(D1); - writePinHigh(D6); } bool led_update_kb(led_t led_state) { if (led_update_user(led_state)) { - writePin(D0, !led_state.num_lock); - writePin(D1, !led_state.caps_lock); - writePin(D6, !led_state.scroll_lock); + writePin(D0, led_state.num_lock); + writePin(D1, led_state.caps_lock); + writePin(D6, led_state.scroll_lock); } return true; } diff --git a/keyboards/facew/config.h b/keyboards/facew/config.h index 0dc35e625889d07a6ad34ddcf8f03a5adf7b4261..be442548d04c8eb3b49141f0be6ff18a15bc0177 100644 --- a/keyboards/facew/config.h +++ b/keyboards/facew/config.h @@ -39,4 +39,5 @@ along with this program. If not, see . #define BACKLIGHT_PIN D4 #define BACKLIGHT_LEVELS 3 + #define RGBLIGHT_ANIMATIONS diff --git a/keyboards/facew/facew.c b/keyboards/facew/facew.c index fc176466fe39f2f981be371aecc58c397cd5a612..2f091ae6bdde517290f4ff74c856e1523f3a5f73 100644 --- a/keyboards/facew/facew.c +++ b/keyboards/facew/facew.c @@ -25,13 +25,12 @@ void keyboard_pre_init_kb(void) { void led_init_ports(void) { setPinOutput(D0); setPinOutput(D1); - writePinHigh(D0); - writePinHigh(D1); } bool led_update_kb(led_t led_state) { if (led_update_user(led_state)) { - writePin(D1, !led_state.caps_lock); + writePin(D0, led_state.num_lock); + writePin(D1, led_state.caps_lock); } return true; } diff --git a/keyboards/ft/mars80/config.h b/keyboards/ft/mars80/config.h index 38c3e851a83d9d9c6263f0b9b20d5cd66935748c..8c1ebe4bafeeb559e9b6a10e1c91a0e90113d3de 100644 --- a/keyboards/ft/mars80/config.h +++ b/keyboards/ft/mars80/config.h @@ -40,6 +40,7 @@ along with this program. If not, see . #define BACKLIGHT_PIN D4 #define BACKLIGHT_LEVELS 3 + #define RGBLIGHT_ANIMATIONS #define NO_UART 1 diff --git a/keyboards/ft/mars80/mars80.c b/keyboards/ft/mars80/mars80.c index ca1950353be42e6c64d0d4d4b07dcbfe667b856d..2c628a6a236762cf073715f004fc87a4c5e4f739 100644 --- a/keyboards/ft/mars80/mars80.c +++ b/keyboards/ft/mars80/mars80.c @@ -24,14 +24,12 @@ void keyboard_pre_init_kb(void) { void led_init_ports(void) { setPinOutput(D1); setPinOutput(D6); - writePinHigh(D1); - writePinHigh(D6); } bool led_update_kb(led_t led_state) { if (led_update_user(led_state)) { - writePin(D1, !led_state.caps_lock); - writePin(D6, !led_state.scroll_lock); + writePin(D1, led_state.caps_lock); + writePin(D6, led_state.scroll_lock); } return true; } diff --git a/keyboards/gray_studio/hb85/config.h b/keyboards/gray_studio/hb85/config.h index dff360ec6a050b11ecc4513057d3b73a0827c6d7..f3fb20ec6b3920b1240bd36fe70f848973f2c40b 100644 --- a/keyboards/gray_studio/hb85/config.h +++ b/keyboards/gray_studio/hb85/config.h @@ -33,3 +33,6 @@ along with this program. If not, see . #define RGBLED_NUM 5 #define RGBLIGHT_ANIMATIONS + +#define BACKLIGHT_PIN D4 +#define BACKLIGHT_LEVELS 3 diff --git a/keyboards/gray_studio/hb85/hb85.c b/keyboards/gray_studio/hb85/hb85.c index 57f5e6031456cee8d85ef09ec2bdb77789939ee9..4b3ff64f1e0ededc1a96ca4b0696bc2b5d40dc7b 100644 --- a/keyboards/gray_studio/hb85/hb85.c +++ b/keyboards/gray_studio/hb85/hb85.c @@ -27,16 +27,13 @@ void led_init_ports(void) { setPinOutput(D0); setPinOutput(D1); setPinOutput(D6); - writePinHigh(D0); - writePinHigh(D1); - writePinHigh(D6); } bool led_update_kb(led_t led_state) { if (led_update_user(led_state)) { - writePin(D0, !led_state.num_lock); - writePin(D1, !led_state.caps_lock); - writePin(D6, !led_state.scroll_lock); + writePin(D0, led_state.num_lock); + writePin(D1, led_state.caps_lock); + writePin(D6, led_state.scroll_lock); } return true; } diff --git a/keyboards/j80/j80.c b/keyboards/j80/j80.c index 4ac0200a28ac7f2360ec8f03e0b5b8212cff965f..bed30cdecc484b297077984842b93608496bc896 100644 --- a/keyboards/j80/j80.c +++ b/keyboards/j80/j80.c @@ -16,10 +16,21 @@ #include "j80.h" +void keyboard_pre_init_kb(void) { + led_init_ports(); + keyboard_pre_init_user(); +} + +void led_init_ports(void) { + setPinOutput(D0); + setPinOutput(D1); + setPinOutput(D6); +} + bool led_update_kb(led_t led_state) { if (led_update_user(led_state)) { - writePin(D1, led_state.caps_lock); writePin(D0, led_state.num_lock); + writePin(D1, led_state.caps_lock); writePin(D6, led_state.scroll_lock); } return true; diff --git a/keyboards/jc65/v32a/v32a.c b/keyboards/jc65/v32a/v32a.c index 627661a57ca116b6ebeaa53e7fc5dd297f49cf7f..f195e8f61e910f895ce4ce53b41cbbadf915c861 100644 --- a/keyboards/jc65/v32a/v32a.c +++ b/keyboards/jc65/v32a/v32a.c @@ -24,12 +24,11 @@ void keyboard_pre_init_kb(void) { void led_init_ports(void) { setPinOutput(D1); - writePinHigh(D1); } bool led_update_kb(led_t led_state) { if (led_update_user(led_state)) { - writePin(D1, !led_state.caps_lock); + writePin(D1, led_state.caps_lock); } return true; } diff --git a/keyboards/kbdfans/kbdpad/mk1/mk1.c b/keyboards/kbdfans/kbdpad/mk1/mk1.c index f5fe47741b08114952165b3671e9425ada3052c6..540ba358925fcc5270466495399f4006f3957b29 100644 --- a/keyboards/kbdfans/kbdpad/mk1/mk1.c +++ b/keyboards/kbdfans/kbdpad/mk1/mk1.c @@ -23,12 +23,11 @@ void keyboard_pre_init_kb(void) { void led_init_ports(void) { setPinOutput(D0); - writePinHigh(D0); } bool led_update_kb(led_t led_state) { if (led_update_user(led_state)) { - writePin(D0, !led_state.num_lock); + writePin(D0, led_state.num_lock); } return true; } diff --git a/keyboards/mehkee96/mehkee96.c b/keyboards/mehkee96/mehkee96.c index 2da25b6b845f7a5f7ae9e489c83ffe0e6b87e278..ae83a1bb50d77c0d79d22984673bcde4fbcdfee8 100644 --- a/keyboards/mehkee96/mehkee96.c +++ b/keyboards/mehkee96/mehkee96.c @@ -25,14 +25,12 @@ void keyboard_pre_init_kb(void) { void led_init_ports(void) { setPinOutput(D0); setPinOutput(D1); - writePinHigh(D0); - writePinHigh(D1); } bool led_update_kb(led_t led_state) { if (led_update_user(led_state)) { - writePin(D0, !led_state.num_lock); - writePin(D1, !led_state.caps_lock); + writePin(D0, led_state.num_lock); + writePin(D1, led_state.caps_lock); } return true; } diff --git a/keyboards/panc60/panc60.c b/keyboards/panc60/panc60.c index a200b258784846bf01ad28034e8e24e23afb7814..d7ff52963cc97e1b785b985135def20e55372449 100644 --- a/keyboards/panc60/panc60.c +++ b/keyboards/panc60/panc60.c @@ -23,12 +23,11 @@ void keyboard_pre_init_kb(void) { void led_init_ports(void) { setPinOutput(D1); - writePinHigh(D1); } bool led_update_kb(led_t led_state) { if (led_update_user(led_state)) { - writePin(D1, !led_state.caps_lock); + writePin(D1, led_state.caps_lock); } return true; } diff --git a/keyboards/pearl/pearl.c b/keyboards/pearl/pearl.c index cebbc9fcbacfb3c8af3139e4cf9692d6e151959f..b08ee6f88807db9db3214f795ea147d53092e2a0 100644 --- a/keyboards/pearl/pearl.c +++ b/keyboards/pearl/pearl.c @@ -26,16 +26,13 @@ void led_init_ports(void) { setPinOutput(D0); setPinOutput(D1); setPinOutput(D6); - writePinHigh(D0); - writePinHigh(D1); - writePinHigh(D6); } bool led_update_kb(led_t led_state) { if (led_update_user(led_state)) { - writePin(D0, !led_state.num_lock); - writePin(D1, !led_state.caps_lock); - writePin(D6, !led_state.scroll_lock); + writePin(D0, led_state.num_lock); + writePin(D1, led_state.caps_lock); + writePin(D6, led_state.scroll_lock); } return true; } diff --git a/keyboards/percent/canoe/canoe.c b/keyboards/percent/canoe/canoe.c index d3c66dbf139521197d276d9eb5ab6559969dd034..dd31640e6d9bb0b54e695a2a48a8858ae206c0b7 100644 --- a/keyboards/percent/canoe/canoe.c +++ b/keyboards/percent/canoe/canoe.c @@ -24,12 +24,11 @@ void keyboard_pre_init_kb(void) { void led_init_ports(void) { setPinOutput(D1); - writePinHigh(D1); } bool led_update_kb(led_t led_state) { if (led_update_user(led_state)) { - writePin(D1, !led_state.caps_lock); + writePin(D1, led_state.caps_lock); } return true; } diff --git a/keyboards/percent/skog/skog.c b/keyboards/percent/skog/skog.c index 241833937bb80a5018b18b083d6ebbbf10924d11..152fc568450006847f00edfe883a06b89d4218cc 100644 --- a/keyboards/percent/skog/skog.c +++ b/keyboards/percent/skog/skog.c @@ -27,14 +27,12 @@ void keyboard_pre_init_kb(void) { void led_init_ports(void) { setPinOutput(D1); setPinOutput(D6); - writePinHigh(D1); - writePinHigh(D6); } bool led_update_kb(led_t led_state) { if (led_update_user(led_state)) { - writePin(D1, !led_state.caps_lock); - writePin(D6, !led_state.scroll_lock); + writePin(D1, led_state.caps_lock); + writePin(D6, led_state.scroll_lock); } return true; } diff --git a/keyboards/percent/skog_lite/skog_lite.c b/keyboards/percent/skog_lite/skog_lite.c index e611885a6103ca5442e4393b9fcdb968572659d2..95d39821130b311682942702f45475d96fed6862 100644 --- a/keyboards/percent/skog_lite/skog_lite.c +++ b/keyboards/percent/skog_lite/skog_lite.c @@ -24,14 +24,12 @@ void keyboard_pre_init_kb(void) { void led_init_ports(void) { setPinOutput(D1); setPinOutput(D6); - writePinHigh(D1); - writePinHigh(D6); } bool led_update_kb(led_t led_state) { if (led_update_user(led_state)) { - writePin(D1, !led_state.caps_lock); - writePin(D6, !led_state.scroll_lock); + writePin(D1, led_state.caps_lock); + writePin(D6, led_state.scroll_lock); } return true; } diff --git a/keyboards/singa/singa.c b/keyboards/singa/singa.c index 7b60e3c29d802e54edccd1e5eda7f0c41e151648..360b214a31dfcc24ce5d9d2be30512078ddb0253 100644 --- a/keyboards/singa/singa.c +++ b/keyboards/singa/singa.c @@ -23,12 +23,11 @@ void keyboard_pre_init_kb(void) { void led_init_ports(void) { setPinOutput(D1); - writePinHigh(D1); } bool led_update_kb(led_t led_state) { if (led_update_user(led_state)) { - writePin(D1, !led_state.caps_lock); + writePin(D1, led_state.caps_lock); } return true; } diff --git a/keyboards/tgr/alice/alice.c b/keyboards/tgr/alice/alice.c index 9fb4957ac89537b5758a39202e80ae4b42254f91..a4a5c787c617203c0b725a77593224918a793512 100644 --- a/keyboards/tgr/alice/alice.c +++ b/keyboards/tgr/alice/alice.c @@ -26,16 +26,13 @@ void led_init_ports(void) { setPinOutput(D0); setPinOutput(D1); setPinOutput(D6); - writePinHigh(D0); - writePinHigh(D1); - writePinHigh(D6); } bool led_update_kb(led_t led_state) { if (led_update_user(led_state)) { - writePin(D0, !led_state.num_lock); - writePin(D1, !led_state.caps_lock); - writePin(D6, !led_state.scroll_lock); + writePin(D0, led_state.num_lock); + writePin(D1, led_state.caps_lock); + writePin(D6, led_state.scroll_lock); } return true; } diff --git a/keyboards/tgr/jane/jane.c b/keyboards/tgr/jane/jane.c index 24183a0f7b91c2bce707b5dac04c0c690bbb74e6..fabdc0e90c2dc129590d6d256c95625bc59e8ce4 100644 --- a/keyboards/tgr/jane/jane.c +++ b/keyboards/tgr/jane/jane.c @@ -24,14 +24,12 @@ void keyboard_pre_init_kb(void) { void led_init_ports(void) { setPinOutput(D1); setPinOutput(D6); - writePinHigh(D1); - writePinHigh(D6); } bool led_update_kb(led_t led_state) { if (led_update_user(led_state)) { - writePin(D1, !led_state.caps_lock); - writePin(D6, !led_state.scroll_lock); + writePin(D1, led_state.caps_lock); + writePin(D6, led_state.scroll_lock); } return true; } diff --git a/keyboards/unikorn/unikorn.c b/keyboards/unikorn/unikorn.c index 26a5092a59cda20b126930d8300efaeb51de4820..c2c85eb984afcd84556559cdfd0b8f81b089c53d 100644 --- a/keyboards/unikorn/unikorn.c +++ b/keyboards/unikorn/unikorn.c @@ -23,12 +23,11 @@ void keyboard_pre_init_kb(void) { void led_init_ports(void) { setPinOutput(D1); - writePinHigh(D1); } bool led_update_kb(led_t led_state) { if (led_update_user(led_state)) { - writePin(D1, !led_state.caps_lock); + writePin(D1, led_state.caps_lock); } return true; } diff --git a/keyboards/winkeyless/bface/bface.c b/keyboards/winkeyless/bface/bface.c index 49e8bbcd2d42651b41aa3fbf2cf375e1b1cd777d..7d27096bad1d4000878241a78b4b800449fd328f 100644 --- a/keyboards/winkeyless/bface/bface.c +++ b/keyboards/winkeyless/bface/bface.c @@ -25,16 +25,13 @@ void led_init_ports(void) { setPinOutput(D0); setPinOutput(D1); setPinOutput(D6); - writePinHigh(D0); - writePinHigh(D1); - writePinHigh(D6); } bool led_update_kb(led_t led_state) { if (led_update_user(led_state)) { - writePin(D0, !led_state.num_lock); - writePin(D1, !led_state.caps_lock); - writePin(D6, !led_state.scroll_lock); + writePin(D0, led_state.num_lock); + writePin(D1, led_state.caps_lock); + writePin(D6, led_state.scroll_lock); } return true; } diff --git a/keyboards/winkeyless/bmini/bmini.c b/keyboards/winkeyless/bmini/bmini.c index fe3b74be133f328c7232ac2b679a47ab2312b173..6529d440333ebad260dc3eb8f30bc3fef70da056 100644 --- a/keyboards/winkeyless/bmini/bmini.c +++ b/keyboards/winkeyless/bmini/bmini.c @@ -26,16 +26,13 @@ void led_init_ports(void) { setPinOutput(D0); setPinOutput(D1); setPinOutput(D6); - writePinHigh(D0); - writePinHigh(D1); - writePinHigh(D6); } bool led_update_kb(led_t led_state) { if (led_update_user(led_state)) { - writePin(D0, !led_state.num_lock); - writePin(D1, !led_state.caps_lock); - writePin(D6, !led_state.scroll_lock); + writePin(D0, led_state.num_lock); + writePin(D1, led_state.caps_lock); + writePin(D6, led_state.scroll_lock); } return true; } diff --git a/keyboards/winkeyless/bminiex/bminiex.c b/keyboards/winkeyless/bminiex/bminiex.c index 365aeee2b24fc4a583d14941610eb18ea0da22bf..676f88ebf53903447508131a3024fe5794c7fa51 100644 --- a/keyboards/winkeyless/bminiex/bminiex.c +++ b/keyboards/winkeyless/bminiex/bminiex.c @@ -26,16 +26,13 @@ void led_init_ports(void) { setPinOutput(D0); setPinOutput(D1); setPinOutput(D6); - writePinHigh(D0); - writePinHigh(D1); - writePinHigh(D6); } bool led_update_kb(led_t led_state) { if (led_update_user(led_state)) { - writePin(D0, !led_state.num_lock); - writePin(D1, !led_state.caps_lock); - writePin(D6, !led_state.scroll_lock); + writePin(D0, led_state.num_lock); + writePin(D1, led_state.caps_lock); + writePin(D6, led_state.scroll_lock); } return true; } diff --git a/keyboards/ymd75/ymd75.c b/keyboards/ymd75/ymd75.c index 1c5c380390249c4b0d497ff9c55dfc1390cb8763..0870a6cc0270579083da827fabc7b80f5fe4c73b 100644 --- a/keyboards/ymd75/ymd75.c +++ b/keyboards/ymd75/ymd75.c @@ -24,12 +24,11 @@ void keyboard_pre_init_kb(void) { void led_init_ports(void) { setPinOutput(D1); - writePinHigh(D1); } bool led_update_kb(led_t led_state) { if (led_update_user(led_state)) { - writePin(D1, !led_state.caps_lock); + writePin(D1, led_state.caps_lock); } return true; } diff --git a/keyboards/ymd96/ymd96.c b/keyboards/ymd96/ymd96.c index c81435e45af02f539e3f405e9e720afd8c401786..5841decdab31f3ec96bc46454b398125bafebc46 100644 --- a/keyboards/ymd96/ymd96.c +++ b/keyboards/ymd96/ymd96.c @@ -26,14 +26,12 @@ void keyboard_pre_init_kb(void) { void led_init_ports(void) { setPinOutput(D0); setPinOutput(D1); - writePinHigh(D0); - writePinHigh(D1); } bool led_update_kb(led_t led_state) { if (led_update_user(led_state)) { - writePin(D0, !led_state.num_lock); - writePin(D1, !led_state.caps_lock); + writePin(D0, led_state.num_lock); + writePin(D1, led_state.caps_lock); } return true; } diff --git a/keyboards/ymdk/bface/bface.c b/keyboards/ymdk/bface/bface.c index e2810409a8da43786e53f3accf199b88c3c6a675..b35b33376399529737ebb449d3c2374c06f1ab6b 100644 --- a/keyboards/ymdk/bface/bface.c +++ b/keyboards/ymdk/bface/bface.c @@ -23,12 +23,11 @@ void keyboard_pre_init_kb(void) { void led_init_ports(void) { setPinOutput(D1); - writePinHigh(D1); } bool led_update_kb(led_t led_state) { if (led_update_user(led_state)) { - writePin(D1, !led_state.caps_lock); + writePin(D1, led_state.caps_lock); } return true; } diff --git a/keyboards/ymdk_np21/ymdk_np21.c b/keyboards/ymdk_np21/ymdk_np21.c index b7c2001a417c02fdf3bc8f52a393b4dd749f3ba6..63812c9360e2f408882db55ecd8da2a9b5b2fc7c 100644 --- a/keyboards/ymdk_np21/ymdk_np21.c +++ b/keyboards/ymdk_np21/ymdk_np21.c @@ -25,7 +25,6 @@ void keyboard_pre_init_kb(void) { void led_init_ports(void) { setPinOutput(D0); - writePinHigh(D0); } bool led_update_kb(led_t led_state) {