gnu: glade3: Remove sitecustomize.py workaround.

The issue has since been resolved.

* gnu/packages/gnome.scm (glade3)[phases]{fix-tests}: Delete phase.

aux-files: sitecustomize: Cleanup and add explanatory comments.

Fixes <https://issues.guix.gnu.org/50105>.

* gnu/packages/aux-files/python/sitecustomize.py: Add a comment explaining the
general idea, and use sys.prefix instead of sys.executable.

(major_minor): Use the unpacking operator (*) to provide the arguments.
(site_packages_prefix): Use os.path.join to form the path.
(python_site): Likewise.  Use sys.prefix instead of sys.executable.
(all_sites_raw): Split on os.path.pathsep.
(sys.path): Directly splice the result in the list.

Suggested-by: Hartmut Goebel <h.goebel@crazy-compilers.com>
Reported-by: Mathieu Othacehe <othacehe@gnu.org>
Signed-off-by: Maxim Cournoyer <maxim.cournoyer@gmail.com>

guix: packages: Fix repacking of plain tarballs.

Fixes <https://issues.guix.gnu.org/50066>.

* guix/packages.scm (patch-and-repack): Test for a tarball using tarball? and
move the plain file copy to the else clause.

Reported-by: Mathieu Othacehe <othacehe@gnu.org>

gnu: gdb: Normalize indentation.

* gnu/packages/gdb.scm (gdb-10): Fix indentation and remove extraneous
newlines.  Remove trailing #t.
(gdb-minimal): Fix indentation.

gnu: gdb: Patch references to /bin/sh and add debug output.

* gnu/packages/gdb.scm (gdb-10)[outputs]: Add a debug output.
[phases]{patch-paths}: New phase.
[inputs]: Add bash.
(gdb-9.2)[phases]{patch-paths}: Override phase.

gnu: Add ld-gold-wrapper.

* gnu/packages/commencement.scm (ld-gold-wrapper): New variable.

gnu: make-ld-wrapper: Add a LINKER argument.

This allows creating wrappers for other linkers than "ld", such as "ld.gold".

* gnu/packages/base.scm (make-ld-wrapper): New variable.
[linker]: New argument.  Update doc.
<ld>: Use LINKER to derive the linker source.

gnu: gcc-5: Fix powerpc64le-linux build

GCC 5 has a misaligned access to a vector pointer which causes a build failure
when using GCC 8 and later.  Backport upstream fix that was applied on the GCC
6 branch.

* gnu/packages/gcc.scm (gcc-5)[source]: Apply
gcc-5-fix-powerpc64le-build.patch.
* gnu/packages/patches/gcc-5-fix-powerpc64le-build.patch: New file.
* gnu/local.mk (dist_patch_DATA): Register it.

Signed-off-by: Maxim Cournoyer <maxim.cournoyer@gmail.com>

gnu: curl: Honor #:tests?.

* gnu/packages/curl.scm (curl)[phases]{check}: Honor #:tests?.

build: qt-utils: Don't wrap .X-real files.

* guix/build/qt-utils.scm (find-files-to-wrap): Exclude already wrapped
programs.  This is forbidden in wrap-program now due to a738a663a99.

Signed-off-by: Maxim Cournoyer <maxim.cournoyer@gmail.com>

gnu: diffutils: Update to 3.8.

‘coreutils-gnulib-tests.patch’ is applied in the gnulib version shipped
with 3.8.

* gnu/packages/base.scm (diffutils): Update to 3.8.
[source]: Do not apply coreutils-gnulib-tests.patch.

Modified-by: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Signed-off-by: Maxim Cournoyer <maxim.cournoyer@gmail.com>

gnu: diffutils: Fix signal processing.

diffutils has a race condition in its signal processing code which is easy to
trigger on powerpc64le-linux.  More often than not, it causes the ‘colors’
test to fail and therefore the build of the package fails as well.

Add the patch proposed in Debian bug 922552 which fixes the problem.

* gnu/packages/patches/diffutils-fix-signal-processing.patch: New file.
* gnu/local.mk (dist_patch_DATA): Add it.
* gnu/packages/base.scm (diffutils)[source]: Use it.

Signed-off-by: Maxim Cournoyer <maxim.cournoyer@gmail.com>

gnu: gtk+-2: Fix ‘builder’ test.

The signal callbacks in the ‘builder’ testcase have wrong prototypes.
This causes it to fail the “/Builder/Signal Autoconnect” test on
powerpc64le-linux.

Solve the problem by backporting the upstream fix that was applied to
GTK+ 3.0.

* gnu/packages/patches/gtk2-fix-builder-test.patch: New file.
* gnu/local.mk (dist_patch_DATA): Add it.
* gnu/packages/gtk.scm (gtk+-2): Use it.

Signed-off-by: Maxim Cournoyer <maxim.cournoyer@gmail.com>

gnu: tzdata: Update to 2021e.

* gnu/packages/base.scm (tzdata, tzdata-for-tests): Update to 2021e.

Signed-off-by: Maxim Cournoyer <maxim.cournoyer@gmail.com>

gnu: glibc: Look for the current timezone in /etc/localtime.

Fixes <https://issues.guix.gnu.org/50830>.
Reported by podiki on #guix.

Previously, glibc 2.33 would look for
/gnu/store/...-glibc-2.33/etc/localtime instead of /etc/localtime.

* gnu/packages/base.scm (glibc)[arguments]: Remove #:make-flags.
[phases]: In 'pre-configure', modify 'inet/Makefile' instead of
'sunrpc/Makefile' since this is where these bits are in 2.33.
(glibc-2.31)[arguments]: Add 'set-etc-rpc-installation-directory'
phase.
(glibc-2.30): Inherit from GLIBC-2.31.
* gnu/tests/base.scm (run-basic-test)["libc honors /etc/localtime"]: New
test.

Signed-off-by: Maxim Cournoyer <maxim.cournoyer@gmail.com>

gnu: glibc: Remove unneeded nscd patching.

This change had no effect already in glibc 2.29, which has proper
versioning.

* gnu/packages/base.scm (glibc)[arguments]: Remove obsolete
'nscd/nscd_stat.c' 'substitute*' statement.

Signed-off-by: Maxim Cournoyer <maxim.cournoyer@gmail.com>

gnu: python-keras: Skip a flaky test.

* gnu/packages/machine-learning.scm (python-keras)
[phases]{check}: Also skip the test_stateful_metrics test.

bluez: Update to 5.61.

* gnu/packages/linux.scm (bluez): Update to 5.61.

gnu: libnice: Update to 0.1.18-0.47a9633 and disable test-bind test.

This resolves a build failure following the GStreamer update to 1.18.5.

* gnu/packages/networking.scm (libnice): Update to 0.1.18-0.47a9633.
[phases]{disable-failing-tests}: Comment out rather than delete
test-set-port-range; disable the bind test, which is flaky.

gnu: dbus-c++: Fix build.

* gnu/packages/glib.scm (dbus-c++)[inputs]: Add libunwind.