~ruther/qmk_firmware

f9f3a11c2076f6fc378beb8ccbc8500fb060fcf3 — Sergey Vlasov 3 years ago 04cf161
contra, fractal: Remove wrongly copypasted pin E6 manipulation code (#14818)

Apparently the default keymaps for `contra` and `fractal` were derived
from some `planck` keymap which contained code to control the status LED
in the implementation of the `BACKLIT` custom keycode.  Unfortunately,
the code to control the LED manipulated the `E6` pin directly, and it
was copied without changes, but the `contra` and `fractal` boards use
the `E6` pin in the matrix, therefore pressing the key mapped to
`BACKLIT` resulted in phantom keypresses for all keys in the
corresponding column.
2 files changed, 0 insertions(+), 4 deletions(-)

M keyboards/contra/keymaps/default/keymap.c
M keyboards/fractal/keymaps/default/keymap.c
M keyboards/contra/keymaps/default/keymap.c => keyboards/contra/keymaps/default/keymap.c +0 -2
@@ 222,10 222,8 @@ bool process_record_user(uint16_t keycode, keyrecord_t *record) {
        #ifdef BACKLIGHT_ENABLE
          backlight_step();
        #endif
        PORTE &= ~(1<<6);
      } else {
        unregister_code(KC_RSFT);
        PORTE |= (1<<6);
      }
      return false;
      break;

M keyboards/fractal/keymaps/default/keymap.c => keyboards/fractal/keymaps/default/keymap.c +0 -2
@@ 213,10 213,8 @@ bool process_record_user(uint16_t keycode, keyrecord_t *record) {
            #ifdef BACKLIGHT_ENABLE
              backlight_step();
            #endif
            PORTE &= ~(1<<6);
          } else {
            unregister_code(KC_RSFT);
            PORTE |= (1<<6);
          }
          return false;
          break;