From bbd4b5eb887a9e5065765d2d6f2ac919d81a38c6 Mon Sep 17 00:00:00 2001 From: fauxpark Date: Sun, 17 Feb 2019 03:11:15 +1100 Subject: [PATCH] Remove redundant KC_TRNS and KC_NO fillers in layouts (#5142) --- layouts/community/ergodox/adam/keymap.c | 3 --- layouts/community/ergodox/belak/keymap.c | 1 - layouts/community/ergodox/familiar/keymap.c | 4 ---- layouts/community/ergodox/haegin/keymap.c | 2 -- layouts/community/ergodox/meagerfindings/keymap.c | 1 - layouts/community/ergodox/xyverz/keymap.c | 5 ----- layouts/community/ortho_4x12/bakingpy/keymap.c | 1 - layouts/community/ortho_4x12/colemak_mod_dh_wide/keymap.c | 4 ---- layouts/community/ortho_4x12/crs/keymap.c | 4 ---- layouts/community/ortho_4x12/ergodoxish/keymap.c | 6 +----- layouts/community/ortho_4x12/grahampheath/keymap.c | 4 ---- layouts/community/ortho_4x12/mindsound/keymap.c | 4 ---- layouts/community/ortho_4x12/symbolic/keymap.c | 6 ------ layouts/community/ortho_4x12/xyverz/keymap.c | 4 ---- layouts/community/ortho_5x12/xyverz/keymap.c | 4 ---- layouts/default/numpad_5x4/default_numpad_5x4/keymap.c | 3 --- layouts/default/ortho_5x4/default_ortho_5x4/keymap.c | 3 --- 17 files changed, 1 insertion(+), 58 deletions(-) diff --git a/layouts/community/ergodox/adam/keymap.c b/layouts/community/ergodox/adam/keymap.c index e99e5d45353ee29ec1140b63bfb7eec8deed40e3..100bb68198173d4dfb6c786837060a88c9427ab0 100644 --- a/layouts/community/ergodox/adam/keymap.c +++ b/layouts/community/ergodox/adam/keymap.c @@ -11,9 +11,6 @@ #define SFLOCK 11 // symbols arrows and F keys on F held down #define SJLOCK 12 // same as Flock but with fall thru J and mapped to J held down -#define _______ KC_TRNS -#define XXXXXXX KC_NO - // Sends macro when key is tapped, presses mod when key is held #define tap_mod_macro(record, mod, macro) ( ((record)->event.pressed) ? \ ( ((record)->tap.count <= 0 || (record)->tap.interrupted) ? MACRO(D(mod), END) : MACRO_NONE ) : \ diff --git a/layouts/community/ergodox/belak/keymap.c b/layouts/community/ergodox/belak/keymap.c index 016cf30b4b4bb924a3144d9869cfd243824f6d2b..bca0dec913fd8fc08fa475f5b481b8912dc03c8e 100644 --- a/layouts/community/ergodox/belak/keymap.c +++ b/layouts/community/ergodox/belak/keymap.c @@ -5,7 +5,6 @@ #include "eeprom.h" #define LAYER_ON(pos) ((layer_state) & (1<<(pos))) -#define _______ KC_TRNS #define EECONFIG_BELAK_MAGIC (uint16_t)0xBE42 diff --git a/layouts/community/ergodox/familiar/keymap.c b/layouts/community/ergodox/familiar/keymap.c index bc513c0cc43cd58d6548ab7c2cceea1a66ff0285..b359a91d367735f5f8fbc06caaa5c29db329445f 100644 --- a/layouts/community/ergodox/familiar/keymap.c +++ b/layouts/community/ergodox/familiar/keymap.c @@ -10,10 +10,6 @@ #define NUMP 3 // numpad #define ARRW 4 // function, media, arrow keys -// Fillers to make layering more clear -#define _______ KC_TRNS -#define XXXXXXX KC_NO - // Tap Dancing void dance_lock (qk_tap_dance_state_t *state, void *user_data) { if (state->count == 1) { // Press once for NUMLOCK diff --git a/layouts/community/ergodox/haegin/keymap.c b/layouts/community/ergodox/haegin/keymap.c index aa017c8ea53b75e6a1d8fedfea356cd4b4c0e82c..fc6ec576221ee9b0606476ff651efbc95e53cb14 100644 --- a/layouts/community/ergodox/haegin/keymap.c +++ b/layouts/community/ergodox/haegin/keymap.c @@ -9,8 +9,6 @@ #define SYMBOLS 1 // symbols #define MEDIA 2 // media keys -#define _______ KC_TRNS - enum { TD_BSPC = 0 }; diff --git a/layouts/community/ergodox/meagerfindings/keymap.c b/layouts/community/ergodox/meagerfindings/keymap.c index 62504f9667a3c5e95e2a33c73c2d939e9e00dcc8..f4340b8e1b45dee814d9b21dde909a8fb99d05b3 100644 --- a/layouts/community/ergodox/meagerfindings/keymap.c +++ b/layouts/community/ergodox/meagerfindings/keymap.c @@ -42,7 +42,6 @@ enum custom_keycodes { }; //Redefine Key Names for Readaibilty -#define XXXXXXX KC_NO #define SCRN_CLIPB LCTL(LGUI(LSFT(KC_4))) #define CHRM_L LALT(LGUI(KC_LEFT)) //Move left one tab in Chrome #define CHRM_R LALT(LGUI(KC_RIGHT)) //Move right one tab in Chrome diff --git a/layouts/community/ergodox/xyverz/keymap.c b/layouts/community/ergodox/xyverz/keymap.c index fe9080c2d645aafbb4c54dec1ba67c35e0d30bfe..eeeded47fcfd5a933af3f847f821f85e8a06ec8b 100644 --- a/layouts/community/ergodox/xyverz/keymap.c +++ b/layouts/community/ergodox/xyverz/keymap.c @@ -31,11 +31,6 @@ extern keymap_config_t keymap_config; #define QWERTY M(_QW) #define COLEMAK M(_CM) -// Fillers to make layering more clear -#define _______ KC_TRNS -#define XXXXXXX KC_NO - - const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = { /* Layer 0 : Dvorak diff --git a/layouts/community/ortho_4x12/bakingpy/keymap.c b/layouts/community/ortho_4x12/bakingpy/keymap.c index 06e4a589c5b83e7740bedba3f5f4ef68024493e7..71672d05134747c3c1d1ddc41a9dbb23f410c8c5 100644 --- a/layouts/community/ortho_4x12/bakingpy/keymap.c +++ b/layouts/community/ortho_4x12/bakingpy/keymap.c @@ -21,7 +21,6 @@ enum custom_keycodes { }; #define KC_ KC_TRNS -#define _______ KC_TRNS #define KC_CAPW LGUI(LSFT(KC_3)) // Capture whole screen #define KC_CPYW LGUI(LSFT(LCTL(KC_3))) // Copy whole screen diff --git a/layouts/community/ortho_4x12/colemak_mod_dh_wide/keymap.c b/layouts/community/ortho_4x12/colemak_mod_dh_wide/keymap.c index 218ff93741fe04946e8fb69c1541296ae13006a3..c8da7f589f535ce47b7eaa1901bc37b65390ef5b 100644 --- a/layouts/community/ortho_4x12/colemak_mod_dh_wide/keymap.c +++ b/layouts/community/ortho_4x12/colemak_mod_dh_wide/keymap.c @@ -20,10 +20,6 @@ enum custom_keycodes { ADJUST, }; -// Fillers to make layering more clear -#define _______ KC_TRNS -#define XXXXXXX KC_NO - const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = { /* Colemak diff --git a/layouts/community/ortho_4x12/crs/keymap.c b/layouts/community/ortho_4x12/crs/keymap.c index f9c72f25433ba57aacc007510ff60172dbe02dac..2ec2ffba9f5d987b23cff323224229541471b9f7 100644 --- a/layouts/community/ortho_4x12/crs/keymap.c +++ b/layouts/community/ortho_4x12/crs/keymap.c @@ -33,10 +33,6 @@ enum custom_keycodes { EXT_PLV }; -// Fillers to make layering more clear -#define _______ KC_TRNS -#define XXXXXXX KC_NO - const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = { /* Qwerty diff --git a/layouts/community/ortho_4x12/ergodoxish/keymap.c b/layouts/community/ortho_4x12/ergodoxish/keymap.c index 49600aa33e07b70661bc919cd3d60c1f62490ebf..7c844c6b3a043a12783e05981b1e99bcb6d540e6 100644 --- a/layouts/community/ortho_4x12/ergodoxish/keymap.c +++ b/layouts/community/ortho_4x12/ergodoxish/keymap.c @@ -24,10 +24,6 @@ enum custom_keycodes { ADJUST, }; -// Fillers to make layering more clear -#define _______ KC_TRNS -#define XXXXXXX KC_NO - const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = { /* Qwerty @@ -211,4 +207,4 @@ bool process_record_user(uint16_t keycode, keyrecord_t *record) { break; } return true; -} \ No newline at end of file +} diff --git a/layouts/community/ortho_4x12/grahampheath/keymap.c b/layouts/community/ortho_4x12/grahampheath/keymap.c index 0b84b66eb88905fce0ab36cc5a651a60f8b74bc1..7b35c52e718e2e80393de0e85a563c6c68720f06 100644 --- a/layouts/community/ortho_4x12/grahampheath/keymap.c +++ b/layouts/community/ortho_4x12/grahampheath/keymap.c @@ -54,10 +54,6 @@ enum custom_keycodes { #define HYPR_1 HYPR(KC_EXLM) // Send Hyper + !. #define HYPR_2 HYPR(KC_AT) // Send Hyper + @. -// Fillers to make layering more clear -#define _______ KC_TRNS -#define XXXXXXX KC_NO - const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = { /* Qwerty diff --git a/layouts/community/ortho_4x12/mindsound/keymap.c b/layouts/community/ortho_4x12/mindsound/keymap.c index 2c9ceaf69071ce79bf05e504757cc5fd8fad2e34..03b0486c58f8cd459457545ab15fd14d2569c5e1 100644 --- a/layouts/community/ortho_4x12/mindsound/keymap.c +++ b/layouts/community/ortho_4x12/mindsound/keymap.c @@ -33,10 +33,6 @@ const uint8_t flicker_max_levels = 7; uint8_t flicker_restore_level = 0; #endif -// Fillers to make layering more clear -#define _______ KC_TRNS -#define XXXXXXX KC_NO - #define LOWER MO(_LOWER) #define RAISE MO(_RAISE) diff --git a/layouts/community/ortho_4x12/symbolic/keymap.c b/layouts/community/ortho_4x12/symbolic/keymap.c index d4c08923685d09095e4b988318df7d78e459f987..1e5494d96ef904b9bfb0e744d9e137bb5297c93b 100644 --- a/layouts/community/ortho_4x12/symbolic/keymap.c +++ b/layouts/community/ortho_4x12/symbolic/keymap.c @@ -19,12 +19,6 @@ enum custom_keycodes { R_RAISE }; - -// Fillers to make layering more clear -#define _______ KC_TRNS -#define XXXXXXX KC_NO - - const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = { /* Qwerty diff --git a/layouts/community/ortho_4x12/xyverz/keymap.c b/layouts/community/ortho_4x12/xyverz/keymap.c index 72ddbacf82027513d455d8e40e4afe72134c4e9e..681dafacd44915a13d1c3a074737b1c653fe2779 100644 --- a/layouts/community/ortho_4x12/xyverz/keymap.c +++ b/layouts/community/ortho_4x12/xyverz/keymap.c @@ -24,10 +24,6 @@ enum custom_keycodes { ADJUST }; -// Fillers to make layering more clear -#define _______ KC_TRNS -#define XXXXXXX KC_NO - // Aliases to keep the keymap tidy #define GUIBSPC GUI_T(KC_BSPC) // GUI when held, BSPC when tapped. #define RGB_SWR RGB_M_SW // Swirl Animation alias diff --git a/layouts/community/ortho_5x12/xyverz/keymap.c b/layouts/community/ortho_5x12/xyverz/keymap.c index 23a456e6d6d48241551544a91c86c22c58726097..bbf1d7bb0eae8e3293043bb7e7b50dc768f5704d 100644 --- a/layouts/community/ortho_5x12/xyverz/keymap.c +++ b/layouts/community/ortho_5x12/xyverz/keymap.c @@ -24,10 +24,6 @@ enum custom_keycodes { ADJUST, }; -// Fillers to make layering more clear -#define _______ KC_TRNS -#define XXXXXXX KC_NO - // Aliases to keep the keymap tidy #define GUIBSPC GUI_T(KC_BSPC) // GUI when held, BSPC when tapped. #define RGB_SWR RGB_M_SW // Swirl Animation alias diff --git a/layouts/default/numpad_5x4/default_numpad_5x4/keymap.c b/layouts/default/numpad_5x4/default_numpad_5x4/keymap.c index 1d68fb2f84d768b8094745cbb28dab06b2cafe37..0e913248f2fde1cf8922dbcc97e9d49943c37418 100644 --- a/layouts/default/numpad_5x4/default_numpad_5x4/keymap.c +++ b/layouts/default/numpad_5x4/default_numpad_5x4/keymap.c @@ -1,8 +1,5 @@ #include QMK_KEYBOARD_H -#define _______ KC_TRNS -#define XXXXXXX KC_NO - const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = { [0] = LAYOUT_numpad_5x4( TG(1), KC_PSLS, KC_PAST, KC_PMNS, \ diff --git a/layouts/default/ortho_5x4/default_ortho_5x4/keymap.c b/layouts/default/ortho_5x4/default_ortho_5x4/keymap.c index 061f06c381d962679f233d64160f0a7a22b2f4f3..39d397d9096f9e6e0fe9aeed9b734060f396c78c 100644 --- a/layouts/default/ortho_5x4/default_ortho_5x4/keymap.c +++ b/layouts/default/ortho_5x4/default_ortho_5x4/keymap.c @@ -1,8 +1,5 @@ #include QMK_KEYBOARD_H -#define _______ KC_TRNS -#define XXXXXXX KC_NO - enum custom_keycodes { KC_P00 = SAFE_RANGE };