~ruther/qmk_firmware

94e94ffb5bbe61b5da4aad205016923746010b23 — Joel Challis 4 years ago cfc9a35
Recommend use of LED Indicator config (#10895)

* Recommend use of LED Indicator config

* Recommend use of LED Indicator config - update link

* Update quantum/template/ps2avrgb/config.h

Co-authored-by: Ryan <fauxpark@gmail.com>

Co-authored-by: Ryan <fauxpark@gmail.com>
3 files changed, 12 insertions(+), 1 deletions(-)

M docs/pr_checklist.md
M quantum/template/avr/config.h
M quantum/template/ps2avrgb/config.h
M docs/pr_checklist.md => docs/pr_checklist.md +1 -0
@@ 73,6 73,7 @@ https://github.com/qmk/qmk_firmware/pulls?q=is%3Apr+is%3Aclosed+label%3Akeyboard
    - commented-out functions removed too
    - `matrix_init_board()` etc. migrated to `keyboard_pre_init_kb()`, see: [keyboard_pre_init*](https://docs.qmk.fm/#/custom_quantum_functions?id=keyboard_pre_init_-function-documentation)
    - prefer `CUSTOM_MATRIX = lite` if custom matrix used, allows for standard debounce, see [custom matrix 'lite'](https://docs.qmk.fm/#/custom_matrix?id=lite)
    - prefer LED indicator [Configuration Options](https://docs.qmk.fm/#/feature_led_indicators?id=configuration-options) to custom `led_update_*()` implementations where possible
- `keyboard.h`
    - `#include "quantum.h"` appears at the top
    - `LAYOUT` macros should use standard definitions if applicable

M quantum/template/avr/config.h => quantum/template/avr/config.h +6 -0
@@ 52,6 52,12 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
#define SOFT_SERIAL_PIN D0  // or D1, D2, D3, E6

//#define LED_NUM_LOCK_PIN B0
//#define LED_CAPS_LOCK_PIN B1
//#define LED_SCROLL_LOCK_PIN B2
//#define LED_COMPOSE_PIN B3
//#define LED_KANA_PIN B4

//#define BACKLIGHT_PIN B7
//#define BACKLIGHT_LEVELS 3
//#define BACKLIGHT_BREATHING

M quantum/template/ps2avrgb/config.h => quantum/template/ps2avrgb/config.h +5 -1
@@ 47,8 47,12 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
/* COL2ROW, ROW2COL */
#define DIODE_DIRECTION COL2ROW

//#define LED_NUM_LOCK_PIN D0
//#define LED_CAPS_LOCK_PIN D1
//#define LED_SCROLL_LOCK_PIN D6

#define BACKLIGHT_PIN D4
#define BACKLIGHT_LEVELS 3
//#define BACKLIGHT_LEVELS 3
//#define BACKLIGHT_BREATHING

#define RGBLED_NUM 16