~ruther/qmk_firmware: Reset `matrix_need_update` properly in eager debouncing algorithms (#21154)

90ea9e447adb16151974c8d29c18bbb140bde9dc — dexter93 2 years ago a059d12

Reset `matrix_need_update` properly in eager debouncing algorithms (#21154)

The `matrix_need_update` variable needs to be reset to `false` in
`transfer_matrix_values()`, otherwise that function continues to be
invoked for every scanning loop (forever with `sym_eager_pk` and
`sym_eager_pk`, or until some key gets released with
`asym_eager_defer_pk`), and the scanning rate gets much lower because of
all that useless work.

Co-authored-by: Sergey Vlasov <sigprof@gmail.com>

patch browse .tar.gz

3 files changed, 4 insertions(+), 0 deletions(-)

M quantum/debounce/asym_eager_defer_pk.c
M quantum/debounce/sym_eager_pk.c
M quantum/debounce/sym_eager_pr.c

M quantum/debounce/asym_eager_defer_pk.c => quantum/debounce/asym_eager_defer_pk.c +2 -0

@@ 144,6 144,8 @@ static void update_debounce_counters_and_transfer_if_expired(matrix_row_t raw[],
 static void transfer_matrix_values(matrix_row_t raw[], matrix_row_t cooked[], uint8_t num_rows) {
     debounce_counter_t *debounce_pointer = debounce_counters;
 
+    matrix_need_update = false;
+
     for (uint8_t row = 0; row < num_rows; row++) {
         matrix_row_t delta = raw[row] ^ cooked[row];
         for (uint8_t col = 0; col < MATRIX_COLS; col++) {

M quantum/debounce/sym_eager_pk.c => quantum/debounce/sym_eager_pk.c +1 -0

@@ 125,6 125,7 @@ static void update_debounce_counters(uint8_t num_rows, uint8_t elapsed_time) {
 
 // upload from raw_matrix to final matrix;
 static void transfer_matrix_values(matrix_row_t raw[], matrix_row_t cooked[], uint8_t num_rows) {
+    matrix_need_update                   = false;
     debounce_counter_t *debounce_pointer = debounce_counters;
     for (uint8_t row = 0; row < num_rows; row++) {
         matrix_row_t delta        = raw[row] ^ cooked[row];

M quantum/debounce/sym_eager_pr.c => quantum/debounce/sym_eager_pr.c +1 -0

@@ 119,6 119,7 @@ static void update_debounce_counters(uint8_t num_rows, uint8_t elapsed_time) {
 
 // upload from raw_matrix to final matrix;
 static void transfer_matrix_values(matrix_row_t raw[], matrix_row_t cooked[], uint8_t num_rows) {
+    matrix_need_update                   = false;
     debounce_counter_t *debounce_pointer = debounce_counters;
     for (uint8_t row = 0; row < num_rows; row++) {
         matrix_row_t existing_row = cooked[row];