~ruther/qmk_firmware: Modified tmk_core/rules.mk to avoid linking errors (#10728)

90c7ae70c68662c671ee1026d1c5abe67026c473 — Fabián González Martín 4 years ago ef49a92

Modified tmk_core/rules.mk to avoid linking errors (#10728)

* Modified tmk_core/rules.mk to avoid linking errors

Added -fcommon flag to avoid linking errors due to multiple variable definitions. Though this is neither a definitive nor good solution, proper changes and use of extern  keyword to avoid those multiple definitions must be made

* Comment updated

patch browse .tar.gz

1 files changed, 5 insertions(+), 0 deletions(-)

M tmk_core/rules.mk

M tmk_core/rules.mk => tmk_core/rules.mk +5 -0

@@ 108,6 108,10 @@ endif
 CFLAGS += -Wa,-adhlns=$(@:%.o=%.lst)
 CFLAGS += $(CSTANDARD)
 
+# This fixes lots of keyboards linking errors but SHOULDN'T BE A FINAL SOLUTION
+# Fixing of multiple variable definitions must be made.
+CFLAGS += -fcommon
+
 #---------------- Compiler Options C++ ----------------
 #  -g*:          generate debugging information
 #  -O*:          optimization level


@@ 124,6 128,7 @@ CXXFLAGS += -O$(OPT)
 CXXFLAGS += -w
 CXXFLAGS += -Wall
 CXXFLAGS += -Wundef
+
 ifneq ($(strip $(ALLOW_WARNINGS)), yes)
     CXXFLAGS += -Werror
 endif