~ruther/qmk_firmware

7182e9a8ad5e5baa36be5c032c16923396838b3f — esinlayo 5 years ago 3b1f29a 
[Keyboard] Remove i2c write command when reading columns on Ergodox EZ (#8092)

* Remove i2c write command when reading cols on Ergodox EZ

* Comment on mcp23018 address state during read_cols
patch browse .tar.gz 
1 files changed, 2 insertions(+), 4 deletions(-)

M keyboards/ergodox_ez/matrix.c

M keyboards/ergodox_ez/matrix.c => keyboards/ergodox_ez/matrix.c +2 -4
@@ 208,10 208,8 @@ static matrix_row_t read_cols(uint8_t row) {
      return 0;
    } else {
      uint8_t data    = 0;
      mcp23018_status = i2c_start(I2C_ADDR_WRITE, ERGODOX_EZ_I2C_TIMEOUT);
      if (mcp23018_status) goto out;
      mcp23018_status = i2c_write(GPIOB, ERGODOX_EZ_I2C_TIMEOUT);
      if (mcp23018_status) goto out;
      // reading GPIOB (column port) since in mcp23018's sequential mode
      // it is addressed directly after writing to GPIOA in select_row()
      mcp23018_status = i2c_start(I2C_ADDR_READ, ERGODOX_EZ_I2C_TIMEOUT);
      if (mcp23018_status) goto out;
      mcp23018_status = i2c_read_nack(ERGODOX_EZ_I2C_TIMEOUT);