~ruther/qmk_firmware

6fd20acf4be76e7a2bd82d3dfd0a9bcca8c507eb — Drashna Jaelre 4 years ago d57d9ae
Fix Mouse Shared EP functionality (#14136)

Specifically, if you enable the shared endpoint for mouse reports (or keyboard, which force enables it for mouse), and you don't have mousekeys enabled, it does not properly enable shared mouse EP for pointing device (which uses mouse reports).   This cause it to error out in compiling.  This fixes up some of the logic to ensure that all use cases are supported, and consolidates some of the code.
2 files changed, 4 insertions(+), 3 deletions(-)

M common_features.mk
M tmk_core/common.mk
M common_features.mk => common_features.mk +2 -2
@@ 117,13 117,13 @@ endif

ifeq ($(strip $(MOUSEKEY_ENABLE)), yes)
    OPT_DEFS += -DMOUSEKEY_ENABLE
    OPT_DEFS += -DMOUSE_ENABLE
    MOUSE_ENABLE := yes
    SRC += $(QUANTUM_DIR)/mousekey.c
endif

ifeq ($(strip $(POINTING_DEVICE_ENABLE)), yes)
    OPT_DEFS += -DPOINTING_DEVICE_ENABLE
    OPT_DEFS += -DMOUSE_ENABLE
    MOUSE_ENABLE := yes
    SRC += $(QUANTUM_DIR)/pointing_device.c
endif


M tmk_core/common.mk => tmk_core/common.mk +2 -1
@@ 25,7 25,8 @@ ifeq ($(strip $(KEYBOARD_SHARED_EP)), yes)
    MOUSE_SHARED_EP = yes
endif

ifeq ($(strip $(MOUSEKEY_ENABLE)), yes)
ifeq ($(strip $(MOUSE_ENABLE)), yes)
    OPT_DEFS += -DMOUSE_ENABLE
    ifeq ($(strip $(MOUSE_SHARED_EP)), yes)
        TMK_COMMON_DEFS += -DMOUSE_SHARED_EP
        SHARED_EP_ENABLE = yes