From 6a4884e3bdc157a00718eb157f72489c1adf30e0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Konstantin=20=C4=90or=C4=91evi=C4=87?= Date: Tue, 19 Mar 2019 22:33:44 +0100 Subject: [PATCH] [Keyboard] Remove unnecessary IS_COMMAND definitions from a couple of boards (#5269) * Remove unnecessary IS_COMMAND definition from clueboard/66_hotswap/gen1 * Remove old-style IS_COMMAND definition comment from dozen0 * Use get_mods() instead of keyboard_report->mods in georgi --- keyboards/clueboard/66_hotswap/gen1/config.h | 5 ----- keyboards/dozen0/config.h | 5 ----- keyboards/georgi/config.h | 4 ++-- 3 files changed, 2 insertions(+), 12 deletions(-) diff --git a/keyboards/clueboard/66_hotswap/gen1/config.h b/keyboards/clueboard/66_hotswap/gen1/config.h index 6b0cfb60b53cf48c6357dee48403b0d2ded2ea63..795adecd56e037bb98fc2ce8ac46cb027d4beca1 100644 --- a/keyboards/clueboard/66_hotswap/gen1/config.h +++ b/keyboards/clueboard/66_hotswap/gen1/config.h @@ -80,11 +80,6 @@ */ //#define FORCE_NKRO -/* key combination for magic key command */ -#define IS_COMMAND() ( \ - keyboard_report->mods == (MOD_BIT(KC_LSHIFT) | MOD_BIT(KC_RSHIFT)) \ -) - /* * Feature disable options * These options are also useful to firmware size reduction. diff --git a/keyboards/dozen0/config.h b/keyboards/dozen0/config.h index 3c409350d553b2e0e6f1b2d9bf6734e2aa333bda..6b0f8525a3d11409ab72ccdc9f368764dba652bc 100644 --- a/keyboards/dozen0/config.h +++ b/keyboards/dozen0/config.h @@ -112,11 +112,6 @@ along with this program. If not, see . * */ -/* key combination for magic key command */ -/*#define IS_COMMAND() ( \ - keyboard_report->mods == (MOD_BIT(KC_LSHIFT) | MOD_BIT(KC_RSHIFT)) \ -)*/ - /* control how magic key switches layers */ //#define MAGIC_KEY_SWITCH_LAYER_WITH_FKEYS true //#define MAGIC_KEY_SWITCH_LAYER_WITH_NKEYS true diff --git a/keyboards/georgi/config.h b/keyboards/georgi/config.h index 041567719bbfa75f3d2658ae24eb07c3ab7c6c46..b35762fbcfc7bdd56327ec8b5a7c62d6ccb39ded 100644 --- a/keyboards/georgi/config.h +++ b/keyboards/georgi/config.h @@ -66,8 +66,8 @@ along with this program. If not, see . /* key combination for command */ #define IS_COMMAND() ( \ - keyboard_report->mods == (MOD_BIT(KC_LCTL) | MOD_BIT(KC_RCTL)) || \ - keyboard_report->mods == (MOD_BIT(KC_LSFT) | MOD_BIT(KC_RSFT)) \ + get_mods() == (MOD_BIT(KC_LCTL) | MOD_BIT(KC_RCTL)) || \ + get_mods() == (MOD_BIT(KC_LSFT) | MOD_BIT(KC_RSFT)) \ ) #define DEBOUNCE 5