~ruther/qmk_firmware: `qmk find`: Fix failure with multiple filters (#22497)

62cca5c43a63e694da4596dc41d1251f9c530198 — Sergey Vlasov 1 year, 5 months ago bf3a88a

`qmk find`: Fix failure with multiple filters (#22497)

When multiple `-f FILTER` options were specified, `qmk find` did not
return anything at all instead of printing the list of entries that
matched all of the specified filters.

The problem was that the statement in `_filter_keymap_targets()` that
filled `targets` had a wrong indent and therefore was executed for every
filter instead of only once after applying all filters, and
`valid_keymaps` was actually an iterator and therefore could be used
only once.  Moving the statement outside of the loop fixes the problem.

patch browse .tar.gz

1 files changed, 1 insertions(+), 1 deletions(-)

M lib/python/qmk/search.py

M lib/python/qmk/search.py => lib/python/qmk/search.py +1 -1

@@ 172,7 172,7 @@ def _filter_keymap_targets(target_list: List[Tuple[str, str]], filters: List[str
                 cli.log.warning(f'Unrecognized filter expression: {filter_expr}')
                 continue
 
-            targets = [KeyboardKeymapBuildTarget(keyboard=e[0], keymap=e[1], json=e[2]) for e in valid_keymaps]
+        targets = [KeyboardKeymapBuildTarget(keyboard=e[0], keymap=e[1], json=e[2]) for e in valid_keymaps]
 
     return targets