~ruther/qmk_firmware

4706231831b7b5926052ee1affc7f38a165c7761 — Joakim Tufvegren 4 years ago 89980ff
Fix two out of bounds accesses from #13330. (#13525)

Two occurrences of `MATRIX_ROWS` weren't properly changed to
`ROWS_PER_HAND` in #13330, causing a crash during boot on at least my
Ergodox Infinity (including #13481).
1 files changed, 2 insertions(+), 2 deletions(-)

M quantum/matrix.c
M quantum/matrix.c => quantum/matrix.c +2 -2
@@ 149,7 149,7 @@ static void unselect_row(uint8_t row) {
}

static void unselect_rows(void) {
    for (uint8_t x = 0; x < MATRIX_ROWS; x++) {
    for (uint8_t x = 0; x < ROWS_PER_HAND; x++) {
        unselect_row(x);
    }
}


@@ 214,7 214,7 @@ static void unselect_cols(void) {

__attribute__((weak)) void matrix_init_pins(void) {
    unselect_cols();
    for (uint8_t x = 0; x < MATRIX_ROWS; x++) {
    for (uint8_t x = 0; x < ROWS_PER_HAND; x++) {
        if (row_pins[x] != NO_PIN) {
            setPinInputHigh_atomic(row_pins[x]);
        }