From 0d80c7bd598c1296d31554fe8c82843415696a18 Mon Sep 17 00:00:00 2001
From: Max Rumpf <max.rumpf1998@gmail.com>
Date: Tue, 28 Jan 2020 18:08:39 +0100
Subject: [PATCH] [Keyboard] Fix Pulse4k info.json LAYOUT name (#7965)

* Fix Pulse4k info.json LAYOUT name

* Add missing functions to fix configurator

Add empty encoder functions to the keyboard code, as the configurator doesn't see the keymap defined functions at first.
To be able to override these functions, they are marked as 'weak'.

* Rework encoder functions another time

Default implementation is now provided as part of the keyboard, but they can still be overriden within the keymap (template is commented out by default)
---
 keyboards/maxr1998/pulse4k/info.json             |  2 +-
 .../maxr1998/pulse4k/keymaps/default/keymap.c    | 13 +++----------
 keyboards/maxr1998/pulse4k/pulse4k.c             | 16 ++++++++++++++++
 3 files changed, 20 insertions(+), 11 deletions(-)

diff --git a/keyboards/maxr1998/pulse4k/info.json b/keyboards/maxr1998/pulse4k/info.json
index 0ac4f063c0508070dbc09732238dc2cf44ecc84f..a653f8e09a8552630e8ab84bf5429d2e19bafc11 100644
--- a/keyboards/maxr1998/pulse4k/info.json
+++ b/keyboards/maxr1998/pulse4k/info.json
@@ -6,7 +6,7 @@
   "width": 3,
   "height": 2,
   "layouts": {
-    "LAYOUT_pulse4k": {
+    "LAYOUT": {
       "key_count": 6,
       "layout": [ 
         { "w": 1, "x": 0, "y": 0 }, 
diff --git a/keyboards/maxr1998/pulse4k/keymaps/default/keymap.c b/keyboards/maxr1998/pulse4k/keymaps/default/keymap.c
index 873c87d1f9e51e0eea577e43652dd7b2b3ef8141..67331235baabf2f0405554dbda489d837618f1f6 100644
--- a/keyboards/maxr1998/pulse4k/keymaps/default/keymap.c
+++ b/keyboards/maxr1998/pulse4k/keymaps/default/keymap.c
@@ -31,18 +31,11 @@ const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
 void matrix_init_user(void) {
 }
 
+// Override if necessary
+/*
 void encoder_one_update(bool clockwise) {
-    if (clockwise) {
-        tap_code(KC_PGDN);
-    } else {
-        tap_code(KC_PGUP);
-    }
 }
 
 void encoder_two_update(bool clockwise) {
-    if (clockwise) {
-        tap_code(KC_VOLU);
-    } else {
-        tap_code(KC_VOLD);
-    }
 }
+//*/
diff --git a/keyboards/maxr1998/pulse4k/pulse4k.c b/keyboards/maxr1998/pulse4k/pulse4k.c
index ee3d41ccd1da390fdb8013389f4713eb8948037f..2ec9dca73916051d2cb211ba8e0e4982cbd37d54 100644
--- a/keyboards/maxr1998/pulse4k/pulse4k.c
+++ b/keyboards/maxr1998/pulse4k/pulse4k.c
@@ -59,3 +59,19 @@ void encoder_update_kb(uint8_t index, bool clockwise) {
         } else encoder_two_update(clockwise);
     }
 }
+
+__attribute__((weak)) void encoder_one_update(bool clockwise) {
+    if (clockwise) {
+        tap_code(KC_PGDN);
+    } else {
+        tap_code(KC_PGUP);
+    }
+}
+
+__attribute__((weak)) void encoder_two_update(bool clockwise) {
+    if (clockwise) {
+        tap_code(KC_VOLU);
+    } else {
+        tap_code(KC_VOLD);
+    }
+}