tests: Avoid zero-expression 'begin' form.

* tests/cran.scm ("description->package"): Add body after the expected
pattern in 'match'.

hash: Close or flush sha256 output ports before calling their 'get' procedure.

Slightly different buffering of custom binary output ports in Guile 2.1.7
would lead tests missing 'close-port' or 'force-output' to fail.

* tests/hash.scm ("open-sha256-port, hello"): Add call to 'force-output'
before call to 'get'.
* tests/nar.scm ("write-file puts file in C locale collation order"):
Call 'close-port' before calling 'get-hash'.

build: Unset 'NIX_BUILD_HOOK' when offloading support is missing.

* build-aux/pre-inst-env.in: Export 'NIX_BUILD_HOOK' only when
nix/scripts/offload is executable; unset it otherwise.

services: prosody: Use 'id' to introduce unhygienic top-level identifiers.

* gnu/services/messaging.scm (define-all-configurations): Use 'id' to
introduce raw/literal/unhygienic top-level identifiers.  Fixes
compilation with Guile 2.2.

services: prosody: Make sure 'id' is available at expansion time.

* gnu/services/messaging.scm (id): Use 'define-syntax-rule' instead of
'define' to make sure 'id' is available at expansion time.

gnu: Remove unneeded imports.

* gnu/packages/backup.scm: Remove unneeded (guix build utils) import.
* gnu/packages/finance.scm: Likewise.

guix archive: Allow compilation with Guile 2.2.

* guix/scripts/archive.scm (export-from-store): Avoid shadowing the
top-level '_'.

gnu: inetutils: Enable tests.

* gnu/packages/admin.scm (inetutils)[arguments]: Remove '#:tests? #f'
and #:configure-flags.
[native-inputs]: Add net-tools.

Signed-off-by: Leo Famulari <leo@famulari.name>

gnu: python-pandas: Fix build on 32-bit.

* gnu/packages/patches/python-pandas-skip-failing-tests.patch: New file.
* gnu/local.mk (dist_patch_DATA): Add it.
* gnu/packages/python.scm (python-pandas, python2-pandas): Use it.

gnu: Add python-faker.

* gnu/packages/patches/python-fake-factory-fix-build-32bit.patch: Adjust
paths. Also rename to ...
* gnu/packages/patches/python-faker-fix-build-32bit.patch: ... this.
* gnu/local.mk (dist_patch_DATA): Adjust accordingly.
* gnu/packages/python.scm (python-faker, python2-faker): New variables.
(python-fake-factory)[properties]: Superseded by PYTHON-FAKER.
(python2-fake-factory)[properties]: Superseded by PYTHON2-FAKER.
(python-orator, python2-orator)[propagated-inputs]: Replace
PYTHON-FAKE-FACTORY with PYTHON-FAKER.

gnu: python-matplotlib-documentation: Fix build.

* gnu/packages/python.scm (python-matplotlib-documentation)[native-inputs]:
Add python-mock and graphviz.
[arguments]: Use separate build and install phases; correctly set latex paper size.

Signed-off-by: Marius Bakke <mbakke@fastmail.com>

gnu: iperf: Update to 3.1.7.

* gnu/packages/networking.scm (iperf): Update to 3.1.7.

gnu: libinput: Update to 1.6.3.

* gnu/packages/freedesktop.scm (libinput, libinput-minimal): Update to 1.6.3.

gnu: r: Fix more reproducibility problems.

* gnu/packages/statistics.scm (r)[arguments]: Patch locations in the
build system that need special treatment for reproducibility.

gnu: r: Fix syntax for INSTALL_OPTS.

This is a follow-up to commit 4621acfd8272fa93d0530faa5f015b26a194b587.

* gnu/packages/statistics.scm (r)[arguments]: Ensure that
"--built-timestamp" appears on the same line as the other INSTALL_OPTS.

gnu: bash: Use the bootstrap Guile in 'url-fetch/reset-patch-level'.

Fixes <http://bugs.gnu.org/25775>.
Reported by Sirgazil, Ricardo Wurmus, Andy Wingo, and others.

* guix/download.scm (in-band-download): Always use GUILE.  This reverts
9f05908fb1e3707cae593d94688748294717a546.
* gnu/packages/bash.scm (url-fetch/reset-patch-level): Remove #:guile.
Pass %BOOTSTRAP-GUILE as #:guile to 'url-fetch'.  Remove #:guile-for-build
argument in 'gexp->derivation' call.

gnu: kdevelop: Upgrade to 5.0.4.

* gnu/packages/kde.scm (kdevelop, kdevplatform): Upgrade to 5.0.4.
(kdevplatform)[source]: Use kde mirror instead of github.

Signed-off-by: Marius Bakke <mbakke@fastmail.com>

gnu: pcre2: Update to 10.23.

* gnu/packages/pcre.scm (pcre2): Update to 10.23.
[source]: Remove patch.
[arguments]: Add phase to substitute /bin/echo reference.
* gnu/packages/patches/pcre2-CVE-2016-3191.patch: Delete file.
* gnu/local.mk (dist_patch_DATA): Remove it.

gnu: khal: Update to 0.9.3.

* gnu/packages/calendar.scm (khal): Update to 0.9.3.
[native-inputs]: Use python-pytest-2.9.2.

gnu: gnupg: Update to 2.1.19.

* gnu/packages/gnupg.scm (gnupg): Update to 2.1.19.
[arguments]: Add 'patch-test-paths' phase and remove 'set-gnupg-home' phase.
Add '--enable-gnupg-builddir-envvar' to #:configure-flags.
[source]: Add 'gnupg-2.1-fix-Y2038-test-failure.patch'.
* gnu/packages/patches/gnupg-2.1-fix-Y2038-test-failure.patch: New file.
* gnu/local.mk (dist_patch_DATA): Add it.