gnu: onionshare: Do not set PYTHONPATH directly.

* gnu/packages/tor.scm (onionshare)[arguments]: Use ADD-INSTALLED-PYTHONPATH
in 'check phase.

gnu: onionshare-cli: Update to 2.4.

* gnu/packages/tor.scm (onionshare-cli): Update to 2.4.
[inputs]: Add python-pynacl.
[arguments]: Patch references to /usr/share/tor in 'bake-tor phase; remove
trailing #T; run tests conditionally.

gnu: python-eventlet: Update to 0.33.0.

* gnu/packages/python-xyz.scm (python-eventlet): Update to 0.33.0.
[propagated-inputs]: Add python-six.
[native-inputs]: Add python-nose.
[arguments]: Enable tests; add build phases 'avoid-OSError and
'delete-broken-tests; replace the 'check phase to run nosetests.

gnu: python-pytest-httpserver: Use GUIX_PYTHONPATH.

* gnu/packages/check.scm (python-pytest-httpserver)[arguments]: Use
GUIX_PYTHONPATH instead of PYTHONPATH.

gnu: polkit: Fix elogind configuration.

* gnu/packages/patches/polkit-configure-elogind.patch: New file.
* gnu/local.mk (dist_patch_DATA): Add it.
* gnu/packages/polkit.scm (polkit): Use it.

gnu: mcg: Use GUIX_PYTHONPATH.

* gnu/packages/mpd.scm (mcg)[arguments]: Use GUIX_PYTHONPATH in the wrapper;
and remove trailing #T while we're at it.

shell: Adjust test to expect C_INCLUDE_PATH, not CPATH.

This is a followup to 2a3cd4ee3557fbbdca42b5ec2f3ec4546c270203.

* tests/guix-shell.sh: Expect C_INCLUDE_PATH instead of CPATH.

tests: Adjust opam and pypi tests to simplified inputs.

* tests/opam.scm ("opam->guix-package"): Expect simplified inputs.
* tests/pypi.scm ("pypi->guix-package, package name contains \"-\" followed by digits"):
Likewise.

derivations: Officially deprecate 'build-expression->derivation'.

This procedure had been semi-deprecated since 2014, starting with commit
21b679f6944f4e1f09f949322f5242b761dc22a7!

* guix/derivations.scm (build-expression->derivation): Define using
'define-deprecated'.

build-system/go: Update cross-compilation support to new interface.

* guix/build-system/go.scm (go-cross-build): Remove 'store', 'native-drvs'
and 'target-drvs'; add 'source', 'build-inputs', 'target-inputs', and
'host-inputs'.  Change default value of #:phases.
[builder]: Rewrite as a gexp.
Rewrite body to call 'gexp->derivation' instead of
'build-expression->derivation'.

gnu: gnupg@2.2.32: Hide.

* gnu/packages/gnupg.scm (gnupg-2.2.32)[properties]: New field.

gnu: entangle: Build with Meson 0.59.

* gnu/packages/photo.scm (entangle)[arguments]: Pass #:meson.

gnu: libdmapsharing: Build against libsoup 2.

* gnu/packages/gnome.scm (libdmapsharing)[propagated-inputs]: Change
LIBSOUP to LIBSOUP-MINIMAL-2.

gnu: gthumb: Build with Meson 0.59.

* gnu/packages/gnome.scm (gthumb)[arguments]: Pass #:meson.

gnu: terminator: Use GUIX_PYTHONPATH.

* gnu/packages/gnome.scm (terminator)[arguments]: Use GUIX_PYTHONPATH in
'wrap-program phase.

gnu: terminator: Remove trailing #T.

* gnu/packages/gnome.scm (terminator)[arguments]: Remove trailing #T from
build phases.

gnu: shorah: Use GUIX_PYTHONPATH in wrapper.

* gnu/packages/bioinformatics.scm (shorah)[arguments]: Wrap executable with
GUIX_PYTHONPATH.

gnu: irrlicht: Fix build.

* gnu/packages/games.scm (irrlicht) [phase remove-<sys/systctl.h>]:
<sys/sysctl.h> has been removed from glibc, and it is not used, so remove it.

Signed-off-by: Efraim Flashner <efraim@flashner.co.il>

gnu: python-tablib: Use GUIX_PYTHONPATH instead of PYTHONPATH.

* gnu/packages/python-xyz.scm (python-tablib)[arguments]: Use GUIX_PYTHONPATH
instead of PYTHONPATH in 'check phase.

gnu: gnome: Use at-spi2-core-minimal.

Fixes <https://issues.guix.gnu.org/51916>.
Reported by Vivien Kraus <vivien@planete-kraus.eu>.

* gnu/packages/gnome.scm (gnome)[propagated-inputs]: Replace
at-spi2-core with at-spi2-core-minimal.