~ruther/guix-local: utils: Micro-optimize 'bytevector->base16-string'.

998fb8fa1d6dfe64a0662aeaeb1ce7169b90dd57 — Ludovic Courtès 11 years ago 8601d0d

utils: Micro-optimize 'bytevector->base16-string'.

This reduces run time of (package-derivation s emacs) by ~1.5%.

* guix/utils.scm (bytevector->base16-string): Traverse BV from the end
  so as to use 'string-concatenate' instead of
  'string-concatenate-reverse'.

patch browse .tar.gz

1 files changed, 6 insertions(+), 5 deletions(-)

M guix/utils.scm

M guix/utils.scm => guix/utils.scm +6 -5

@@ 121,12 121,13 @@ evaluate to a simple datum."
                                                     0))))
                                     v))))))
     (define chars base16-chars)
-    (let loop ((i 0)
+    (let loop ((i len)
                (r '()))
-      (if (= i len)
-          (string-concatenate-reverse r)
-          (loop (+ 1 i)
-                (cons (vector-ref chars (bytevector-u8-ref bv i)) r))))))
+      (if (zero? i)
+          (string-concatenate r)
+          (let ((i (- i 1)))
+            (loop i
+                  (cons (vector-ref chars (bytevector-u8-ref bv i)) r)))))))
 
 (define base16-string->bytevector
   (let ((chars->value (fold (lambda (i r)