~ruther/guix-local

788e3b87a7dadf93e3834a0f4397afe5c18355b8 — Nicolas Graves 1 year, 4 months ago 142a3d5
gnu: yajl: Patch CVE-2023-33460.

* gnu/packages/patches/yajl-CVE-2023-33460.patch: Add file.
* gnu/local.mk: Record patch.
* gnu/packages/web.scm (yajl)[source]: Record patch.

Signed-off-by: Zheng Junjie <z572@z572.online>
3 files changed, 42 insertions(+), 1 deletions(-)

M gnu/local.mk
A gnu/packages/patches/yajl-CVE-2023-33460.patch
M gnu/packages/web.scm
M gnu/local.mk => gnu/local.mk +1 -0
@@ 2474,6 2474,7 @@ dist_patch_DATA =						\
  %D%/packages/patches/xterm-370-explicit-xcursor.patch		\
  %D%/packages/patches/xygrib-fix-finding-data.patch		\
  %D%/packages/patches/xygrib-newer-proj.patch			\
  %D%/packages/patches/yajl-CVE-2023-33460.patch		\
  %D%/packages/patches/yggdrasil-extra-config.patch	\
  %D%/packages/patches/zig-0.9-build-respect-PKG_CONFIG-env-var.patch	\
  %D%/packages/patches/zig-0.9-fix-runpath.patch		\

A gnu/packages/patches/yajl-CVE-2023-33460.patch => gnu/packages/patches/yajl-CVE-2023-33460.patch +38 -0
@@ 0,0 1,38 @@
Memory leak in yajl 2.1.0 with use of yajl_tree_parse function
See https://github.com/lloyd/yajl/issues/250#issuecomment-1628695214

Origin: https://github.com/openEuler-BaseService/yajl/commit/23a122eddaa28165a6c219000adcc31ff9a8a698
Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1039984
Bug: https://github.com/lloyd/yajl/issues/250
---
 src/yajl_tree.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/yajl_tree.c b/src/yajl_tree.c
index 3d357a32..56c7012f 100644
--- a/src/yajl_tree.c
+++ b/src/yajl_tree.c
@@ -143,7 +143,7 @@ static yajl_val context_pop(context_t *ctx)
     ctx->stack = stack->next;
 
     v = stack->value;
-
+    free (stack->key);
     free (stack);
 
     return (v);
@@ -444,7 +444,14 @@ yajl_val yajl_tree_parse (const char *input,
              snprintf(error_buffer, error_buffer_size, "%s", internal_err_str);
              YA_FREE(&(handle->alloc), internal_err_str);
         }
+        while(ctx.stack != NULL) {
+             yajl_val v = context_pop(&ctx);
+             yajl_tree_free(v);
+        }
         yajl_free (handle);
+	//If the requested memory is not released in time, it will cause memory leakage
+	if(ctx.root)
+	     yajl_tree_free(ctx.root);
         return NULL;
     }
 

M gnu/packages/web.scm => gnu/packages/web.scm +3 -1
@@ 1749,7 1749,9 @@ C.")
              (file-name (git-file-name name version))
              (sha256
               (base32
                "00yj06drb6izcxfxfqlhimlrb089kka0w0x8k27pyzyiq7qzcvml"))))
                "00yj06drb6izcxfxfqlhimlrb089kka0w0x8k27pyzyiq7qzcvml"))
              (patches
               (search-patches "yajl-CVE-2023-33460.patch"))))
    (build-system cmake-build-system)
    (arguments
     '(#:phases