From 775c7a30536f65c9e1cf87cc61170c372b65a0cb Mon Sep 17 00:00:00 2001
From: Cayetano Santos <csantosb@inventati.org>
Date: Wed, 17 Sep 2025 10:38:59 +0200
Subject: [PATCH] gnu: intelmetool: Improve style.

* gnu/packages/flashing-tools.scm (intelmetool)[source]: Switch url.
[arguments]: Use Gexps.
[home-page]: Update.

Change-Id: Ic4160b1536e6e2fe0ca98bc091c6f8ba411837f9
Signed-off-by: Maxim Cournoyer <maxim@guixotic.coop>
---
 gnu/packages/flashing-tools.scm | 29 +++++++++++++++--------------
 1 file changed, 15 insertions(+), 14 deletions(-)

diff --git a/gnu/packages/flashing-tools.scm b/gnu/packages/flashing-tools.scm
index e6793d1a3217ea719bf9e85976015305a14cb13a..f53960de737a843c4b7fbfc5caf92c4cde4248b3 100644
--- a/gnu/packages/flashing-tools.scm
+++ b/gnu/packages/flashing-tools.scm
@@ -448,7 +448,7 @@ dump Intel Firmware Descriptor data of an image file.")
     (source (origin
               (method git-fetch)
               (uri (git-reference
-                    (url "https://review.coreboot.org/p/coreboot")
+                    (url "https://review.coreboot.org/coreboot")
                     (commit version)))
               (file-name (git-file-name name version))
               (sha256
@@ -458,19 +458,20 @@ dump Intel Firmware Descriptor data of an image file.")
     (inputs
      (list pciutils zlib))
     (arguments
-     `(#:make-flags
-       (list "CC=gcc"
-             "INSTALL=install"
-             (string-append "PREFIX=" (assoc-ref %outputs "out")))
-       #:phases
-       (modify-phases %standard-phases
-        (add-after 'unpack 'chdir
-          (lambda _
-            (chdir "util/intelmetool")
-            #t))
-        (delete 'configure)
-        (delete 'check))))
-    (home-page "https://github.com/zamaudio/intelmetool")
+     (list
+      #:make-flags
+      #~(list (string-append "CC=" #$(cc-for-target))
+              "INSTALL=install"
+              (string-append "PREFIX=" #$output))
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-after 'unpack 'chdir
+            (lambda _
+              (chdir "util/intelmetool")))
+          (delete 'configure) ;no configure script
+          (delete 'check))))
+    (home-page
+     "https://github.com/coreboot/coreboot/tree/main/util/intelmetool/")
     (synopsis "Intel Management Engine tools")
     (description "This package provides tools for working with Intel
 Management Engine (ME).  You need to @code{sudo rmmod mei_me} and