~ruther/guix-local

708d9070006fd46ffe4c2c3cf64154ea4430202a — Ludovic Courtès 10 years ago e134baa
daemon: Add 'buildMode' parameter to 'buildPaths' RPC.

* nix/libstore/worker-protocol.hh (PROTOCOL_VERSION): Bump to 0x10f.
* nix/libstore/remote-store.cc (RemoteStore::buildPaths): Send the
BUILDMODE when the daemon supports it.  Reject invalid values of
BUILDMODE for old daemons.
* nix/nix-daemon/nix-daemon.cc (performOp) <wopBuildPaths>: Read the
build mode when the client supports it.
3 files changed, 20 insertions(+), 4 deletions(-)

M nix/libstore/remote-store.cc
M nix/libstore/worker-protocol.hh
M nix/nix-daemon/nix-daemon.cc
M nix/libstore/remote-store.cc => nix/libstore/remote-store.cc +9 -2
@@ 462,11 462,18 @@ Paths RemoteStore::importPaths(bool requireSignature, Source & source)

void RemoteStore::buildPaths(const PathSet & drvPaths, BuildMode buildMode)
{
    if (buildMode != bmNormal) throw Error("repairing or checking is not supported when building through the Nix daemon");
    openConnection();
    writeInt(wopBuildPaths, to);
    if (GET_PROTOCOL_MINOR(daemonVersion) >= 13)
    if (GET_PROTOCOL_MINOR(daemonVersion) >= 13) {
        writeStrings(drvPaths, to);
        if (GET_PROTOCOL_MINOR(daemonVersion) >= 15) {
            writeInt(buildMode, to);
        }
        /* Old daemons did not take a 'buildMode' parameter, so we need to
           validate it here on the client side.  */
        else if (buildMode != bmNormal) throw Error("repairing or checking \
is not supported when building through the Nix daemon");
    }
    else {
        /* For backwards compatibility with old daemons, strip output
           identifiers. */

M nix/libstore/worker-protocol.hh => nix/libstore/worker-protocol.hh +1 -1
@@ 6,7 6,7 @@ namespace nix {
#define WORKER_MAGIC_1 0x6e697863
#define WORKER_MAGIC_2 0x6478696f

#define PROTOCOL_VERSION 0x10e
#define PROTOCOL_VERSION 0x10f
#define GET_PROTOCOL_MAJOR(x) ((x) & 0xff00)
#define GET_PROTOCOL_MINOR(x) ((x) & 0x00ff)


M nix/nix-daemon/nix-daemon.cc => nix/nix-daemon/nix-daemon.cc +10 -1
@@ 451,8 451,17 @@ static void performOp(bool trusted, unsigned int clientVersion,

    case wopBuildPaths: {
        PathSet drvs = readStorePaths<PathSet>(from);
        BuildMode mode = bmNormal;
        if (GET_PROTOCOL_MINOR(clientVersion) >= 15) {
            mode = (BuildMode)readInt(from);

	    /* Repairing is not atomic, so disallowed for "untrusted"
	       clients.  */
            if (mode == bmRepair && !trusted)
                throw Error("repairing is not supported when building through the Nix daemon");
        }
        startWork();
        store->buildPaths(drvs);
        store->buildPaths(drvs, mode);
        stopWork();
        writeInt(1, to);
        break;