~ruther/guix-local: services: agetty: 'term-console' succeeds by default.

57e731c358d000f614fbda23654cae6a5e79df80 — Ludovic Courtès 3 years ago 9fad606

services: agetty: 'term-console' succeeds by default.

Previously, on a typical setup without "console=ttyS0" or similar in
'kernel-arguments', the 'term-console' Shepherd service would always be
marked as failing to start.  This is undesirable because it raises a
false alarm: the service is expected to do nothing in this case.

This patch instead marks it as succeeding and logs a message explaining
it's doing nothing.

* gnu/services/base.scm (agetty-shepherd-service): In 'start' method,
succeed when TTY is #f and print a message.

patch browse .tar.gz .zip

1 files changed, 7 insertions(+), 1 deletions(-)

M gnu/services/base.scm

M gnu/services/base.scm => gnu/services/base.scm +7 -1

@@ 1178,7 1178,13 @@ to use as the tty.  This is primarily useful for headless systems."
                            #$@(if term
                                   #~(#$term)
                                   #~())))
-                    (const #f))                   ; never start.
+                    #$(if tty
+                          #~(const #f)         ;always fail to start
+                          #~(lambda _          ;succeed, but don't do anything
+                              (format #t "~a: \
+no serial port console requested; doing nothing~%"
+                                      '#$(car provision))
+                              'idle)))
                 args)))))
       (stop #~(make-kill-destructor))))))