From 3505904f8356c3a6fb44be66239621352af28186 Mon Sep 17 00:00:00 2001
From: Ricardo Wurmus <rekado@elephly.net>
Date: Wed, 7 May 2025 10:35:03 +0200
Subject: [PATCH] gnu: r-threejs: Update to 0.3.4.

* gnu/packages/cran.scm (r-threejs): Update to 0.3.4.
[arguments]: Rewrite 'process-javascript phase to use minify-build-system.
[native-inputs]: Replace node-uglify-js with esbuild.

Change-Id: I9d062dedbe7676bd331c8b2ba4fbbdc4fe7efb75
---
 gnu/packages/cran.scm | 53 +++++++++++++++++++------------------------
 1 file changed, 23 insertions(+), 30 deletions(-)

diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
index 58ce4d0b3e7e4a0e6d99b3cc1fa22a8a93e29430..dc9c16c4fb6b1004018949a688d595a6a507c8df 100644
--- a/gnu/packages/cran.scm
+++ b/gnu/packages/cran.scm
@@ -36147,47 +36147,40 @@ and Learning to Rank measures (LambdaMart).")
 (define-public r-threejs
   (package
     (name "r-threejs")
-    (version "0.3.3")
+    (version "0.3.4")
     (source
      (origin
        (method url-fetch)
        (uri (cran-uri "threejs" version))
        (sha256
         (base32
-         "1711h351nzxfkbbdwvfzyhciyvi9c6wx3jq1g97lzcqgnb45kivn"))))
+         "115ldv4df276312bsfigkz28mp2d0xk2izxwvghiw182hzbsasqw"))))
     (build-system r-build-system)
     (arguments
-     `(#:modules ((guix build utils)
-                  (guix build r-build-system)
-                  (srfi srfi-1)
-                  (ice-9 popen))
-       #:phases
-       (modify-phases %standard-phases
-         (add-after 'unpack 'process-javascript
-           (lambda* (#:key inputs #:allow-other-keys)
-             (with-directory-excursion "inst"
-               (call-with-values
-                   (lambda ()
-                     (unzip2
-                      `((,(assoc-ref inputs "js-jquery")
-                         "htmlwidgets/lib/jquery/jquery.min.js")
-                        (,(assoc-ref inputs "js-threejs-111")
-                         "htmlwidgets/lib/threejs-111/three.min.js"))))
-                 (lambda (sources targets)
-                   (for-each (lambda (source target)
-                               (format #t "Processing ~a --> ~a~%"
-                                       source target)
-                               (delete-file target)
-                               (let ((minified (open-pipe* OPEN_READ "uglifyjs" source)))
-                                 (call-with-output-file target
-                                   (lambda (port)
-                                     (dump-port minified port)))))
-                             sources targets))))
-             #t)))))
+     (list
+      #:modules '((guix build r-build-system)
+                  (guix build minify-build-system)
+                  (guix build utils)
+                  (ice-9 match))
+      #:imported-modules `(,@%r-build-system-modules
+                           (guix build minify-build-system))
+      #:phases
+      #~(modify-phases (@ (guix build r-build-system) %standard-phases)
+          (add-after 'unpack 'process-javascript
+            (lambda* (#:key inputs #:allow-other-keys)
+              (with-directory-excursion "inst"
+                (for-each
+                 (match-lambda
+                   ((source . target)
+                    (minify source #:target target)))
+                 `((,(assoc-ref inputs "js-jquery")
+                     . "htmlwidgets/lib/jquery/jquery.min.js")
+                   (,(assoc-ref inputs "js-threejs-111")
+                    . "htmlwidgets/lib/threejs-111/three.min.js")))))))))
     (propagated-inputs
      (list r-base64enc r-crosstalk r-htmlwidgets r-igraph))
     (native-inputs
-     `(("uglifyjs" ,node-uglify-js)
+     `(("esbuild" ,esbuild)
        ("js-jquery"
         ,(origin
            (method url-fetch)