From aae9508c0ea13ccee41fb2738e9b5f77dac8deb8 Mon Sep 17 00:00:00 2001 From: Rahix Date: Sat, 18 May 2019 08:29:51 +0200 Subject: [PATCH] common: Add some comments to the patch files Signed-off-by: Rahix --- patch/common/ac.yaml | 6 ++++++ patch/common/pll.yaml | 10 ++++++++-- patch/common/twi.yaml | 6 ++++++ patch/common/wdt.yaml | 9 +++++++++ 4 files changed, 29 insertions(+), 2 deletions(-) diff --git a/patch/common/ac.yaml b/patch/common/ac.yaml index 6f64486..0e73a4a 100644 --- a/patch/common/ac.yaml +++ b/patch/common/ac.yaml @@ -1,3 +1,9 @@ +# Patches for the Analog Comparator +# +# - Make the control-register actually writable +# - Fix the description of the "Interrupt Mode Select" field +# - Make just the Output field of ACSR read-only +# - Fix the "Interrupt Mode Select" enumerated values AC: _modify: ACSR: diff --git a/patch/common/pll.yaml b/patch/common/pll.yaml index 9d5597f..1d6a685 100644 --- a/patch/common/pll.yaml +++ b/patch/common/pll.yaml @@ -1,3 +1,9 @@ +# Patches for the PLL Clock Generator +# +# - Make the Lock Detector field read-only +# - Add descriptions for "Input Multiplexer" and "USB Postscaler" +# - Remove and re-add the "Lock Frequency" and Postscaler fields +# to fix . PLL: PLLCSR: _modify: @@ -11,13 +17,13 @@ PLL: PINMUX: description: "PLL Input Multiplexer" PLLUSB: - description: "PLL Postcaler for USB Peripheral" + description: "PLL Postscaler for USB Peripheral" _add: PDIV: description: "PLL Lock Frequency" bitRange: "[3:0]" PLLTM: - description: "PLL Postcaler for High Speed Timer" + description: "PLL Postscaler for High Speed Timer" bitRange: "[5:4]" PDIV: MHZ40: [0b0011, "40 MHz"] diff --git a/patch/common/twi.yaml b/patch/common/twi.yaml index c331094..2e62ecc 100644 --- a/patch/common/twi.yaml +++ b/patch/common/twi.yaml @@ -1,3 +1,9 @@ +# Patches for the Two-Wire-Interface peripheral (i2c) +# +# - Make the Control Register read-write with only the +# "Write Collision Flag" being read-only +# - Fix the "Slave Address Mask" description +# - Fix the Prescaler enumerated values TWI: _modify: TWCR: diff --git a/patch/common/wdt.yaml b/patch/common/wdt.yaml index 1223235..e3a5a23 100644 --- a/patch/common/wdt.yaml +++ b/patch/common/wdt.yaml @@ -1,3 +1,12 @@ +# Patches for the Watchdog Timer +# +# The control register has a different name between ATmega and +# ATtiny (WDTCSR vs WDTCR). +# +# - Make the control register read-write +# - Remove the overlapping WDP (Prescaler) field and replace +# it with two separate fields. +# - TODO: See if svd2rust would support some kind of mask? WDT: _modify: WDTCSR,WDTCR: -- 2.48.1