From bc090b22699dd63aaddb7cf12b99c6c3d792c6ac Mon Sep 17 00:00:00 2001 From: Rutherther Date: Sun, 1 Jan 2023 18:39:25 +0100 Subject: [PATCH] feat(game): handle null skill vnum in su packet responder --- .../Entities/SkillUsedResponder.cs | 52 ++++++++----------- 1 file changed, 22 insertions(+), 30 deletions(-) diff --git a/Core/NosSmooth.Game/PacketHandlers/Entities/SkillUsedResponder.cs b/Core/NosSmooth.Game/PacketHandlers/Entities/SkillUsedResponder.cs index 8c2fac8..a39e58c 100644 --- a/Core/NosSmooth.Game/PacketHandlers/Entities/SkillUsedResponder.cs +++ b/Core/NosSmooth.Game/PacketHandlers/Entities/SkillUsedResponder.cs @@ -20,6 +20,7 @@ using NosSmooth.Game.Events.Entities; using NosSmooth.Game.Extensions; using NosSmooth.Game.Helpers; using NosSmooth.Packets.Client.Battle; +using NosSmooth.Packets.Enums; using NosSmooth.Packets.Server.Battle; using NosSmooth.Packets.Server.Skills; using Remora.Results; @@ -29,8 +30,7 @@ namespace NosSmooth.Game.PacketHandlers.Entities; /// /// Responds to skill used packet. /// -public class SkillUsedResponder : IPacketResponder, IPacketResponder, - IPacketResponder +public class SkillUsedResponder : IPacketResponder, IPacketResponder { private readonly Game _game; private readonly EventDispatcher _eventDispatcher; @@ -85,9 +85,9 @@ public class SkillUsedResponder : IPacketResponder, IPacketResponder, IPacketResponder, IPacketResponder, IPacketResponder, IPacketResponder - public async Task Respond(PacketEventArgs packetArgs, CancellationToken ct = default) - { - var packet = packetArgs.Packet; - var character = _game.Character; - - if (character is not null && character.Skills is not null) - { - var skillResult = character.Skills.TryGetSkillByCastId(packet.CastId); - - if (skillResult.IsDefined(out var skillEntity)) - { - skillEntity.IsOnCooldown = true; - } - } - - return Result.FromSuccess(); - } } \ No newline at end of file -- 2.49.0