From 085be37d130638ba8f4d65e00010a763c406c573 Mon Sep 17 00:00:00 2001
From: Rutherther <fandabohacek@gmail.com>
Date: Sun, 1 Jan 2023 23:19:58 +0100
Subject: [PATCH] fix(packets): make bs packet effect id nullable

---
 Packets/NosSmooth.Packets/NosSmooth.Packets.csproj  | 8 ++++----
 Packets/NosSmooth.Packets/Server/Battle/BsPacket.cs | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/Packets/NosSmooth.Packets/NosSmooth.Packets.csproj b/Packets/NosSmooth.Packets/NosSmooth.Packets.csproj
index ebe25f5..75f3d38 100644
--- a/Packets/NosSmooth.Packets/NosSmooth.Packets.csproj
+++ b/Packets/NosSmooth.Packets/NosSmooth.Packets.csproj
@@ -7,11 +7,11 @@
         <Description>Contains default NosTale packets.</Description>
         <RepositoryUrl>https://github.com/Rutherther/NosSmooth/</RepositoryUrl>
         <PackageLicenseExpression>MIT</PackageLicenseExpression>
-        <PackageVersion>2.3.4</PackageVersion>
+        <PackageVersion>2.3.5</PackageVersion>
         <TargetFrameworks>net7.0;netstandard2.1</TargetFrameworks>
-        <PackageReleaseNotes>Make VNum in su packet nullable</PackageReleaseNotes>
-        <AssemblyVersion>2.3.4</AssemblyVersion>
-        <FileVersion>2.3.4</FileVersion>
+        <PackageReleaseNotes>Make BsPacket EffectId nullable</PackageReleaseNotes>
+        <AssemblyVersion>2.3.5</AssemblyVersion>
+        <FileVersion>2.3.5</FileVersion>
     </PropertyGroup>
 
     <ItemGroup>
diff --git a/Packets/NosSmooth.Packets/Server/Battle/BsPacket.cs b/Packets/NosSmooth.Packets/Server/Battle/BsPacket.cs
index ea6114d..5aca851 100644
--- a/Packets/NosSmooth.Packets/Server/Battle/BsPacket.cs
+++ b/Packets/NosSmooth.Packets/Server/Battle/BsPacket.cs
@@ -46,7 +46,7 @@ public record BsPacket
     [PacketIndex(6)]
     long AttackAnimationId,
     [PacketIndex(7)]
-    long EffectId,
+    long? EffectId,
     [PacketIndex(8)]
     int Unknown1,
     [PacketIndex(9)]
-- 
2.48.1