From b0fce8f101fed43c9af9671a28bf671a9c2d82bd Mon Sep 17 00:00:00 2001
From: Rutherther <fandabohacek@gmail.com>
Date: Sat, 11 Feb 2023 20:01:54 +0100
Subject: [PATCH] feat(binding): make options of NosBrowserManager optional

---
 .../NosBrowserManager.cs                      | 24 +++++++++----------
 .../External/ExternalBrowser/Program.cs       | 16 +------------
 2 files changed, 13 insertions(+), 27 deletions(-)

diff --git a/src/Core/NosSmooth.LocalBinding/NosBrowserManager.cs b/src/Core/NosSmooth.LocalBinding/NosBrowserManager.cs
index 7d9f4e64e9f98215ad45133d7d54da12959b997b..fff749adfd7ab811c4f51b454edd0862678620ca 100644
--- a/src/Core/NosSmooth.LocalBinding/NosBrowserManager.cs
+++ b/src/Core/NosSmooth.LocalBinding/NosBrowserManager.cs
@@ -110,20 +110,20 @@ public class NosBrowserManager
     public NosBrowserManager
     (
         Process process,
-        PlayerManagerOptions playerManagerOptions,
-        SceneManagerOptions sceneManagerOptions,
-        PetManagerOptions petManagerOptions,
-        NetworkManagerOptions networkManagerOptions,
-        UnitManagerOptions unitManagerOptions,
-        NtClientOptions ntClientOptions
+        PlayerManagerOptions? playerManagerOptions = default,
+        SceneManagerOptions? sceneManagerOptions = default,
+        PetManagerOptions? petManagerOptions = default,
+        NetworkManagerOptions? networkManagerOptions = default,
+        UnitManagerOptions? unitManagerOptions = default,
+        NtClientOptions? ntClientOptions = default
     )
     {
-        _playerManagerOptions = playerManagerOptions;
-        _sceneManagerOptions = sceneManagerOptions;
-        _petManagerOptions = petManagerOptions;
-        _networkManagerOptions = networkManagerOptions;
-        _unitManagerOptions = unitManagerOptions;
-        _ntClientOptions = ntClientOptions;
+        _playerManagerOptions = playerManagerOptions ?? new PlayerManagerOptions();
+        _sceneManagerOptions = sceneManagerOptions ?? new SceneManagerOptions();
+        _petManagerOptions = petManagerOptions ?? new PetManagerOptions();
+        _networkManagerOptions = networkManagerOptions ?? new NetworkManagerOptions();
+        _unitManagerOptions = unitManagerOptions ?? new UnitManagerOptions();
+        _ntClientOptions = ntClientOptions ?? new NtClientOptions();
         Process = process;
         Memory = Process.Id == Process.GetCurrentProcess().Id ? new Memory() : new ExternalMemory(process);
         Scanner = new Scanner(process, process.MainModule);
diff --git a/src/Samples/External/ExternalBrowser/Program.cs b/src/Samples/External/ExternalBrowser/Program.cs
index 694f4cbf856650ea0b9b0e59db81ed42cb2e1556..bd7c5f10604dd9e482d336b1f5b8fd57bc405cd9 100644
--- a/src/Samples/External/ExternalBrowser/Program.cs
+++ b/src/Samples/External/ExternalBrowser/Program.cs
@@ -23,12 +23,6 @@ public class Program
     /// <param name="arguments">The arguments.</param>
     public static void Main(string[] arguments)
     {
-        var playerManagerOptions = new PlayerManagerOptions();
-        var sceneManagerOptions = new SceneManagerOptions();
-        var petManagerOptions = new PetManagerOptions();
-        var networkManagerOptions = new NetworkManagerOptions();
-        var unitManagerOptions = new UnitManagerOptions();
-
         foreach (var argument in arguments)
         {
             Process[] processes;
@@ -47,15 +41,7 @@ public class Program
 
             foreach (var process in processes)
             {
-                var externalBrowser = new NosBrowserManager
-                (
-                    process,
-                    playerManagerOptions,
-                    sceneManagerOptions,
-                    petManagerOptions,
-                    networkManagerOptions,
-                    unitManagerOptions
-                );
+                var externalBrowser = new NosBrowserManager(process);
 
                 if (!externalBrowser.IsNostaleProcess)
                 {