From f9fb4cfa8b00bea58d389b094939b26800c74873 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Franti=C5=A1ek=20Boh=C3=A1=C4=8Dek?=
 <fandabohacek@gmail.com>
Date: Sun, 20 Jun 2021 23:14:56 +0200
Subject: [PATCH] feat: put errors to enum instead of magic constants in code

---
 text-viewer/src/main.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/text-viewer/src/main.c b/text-viewer/src/main.c
index c885936786f91d5655da1ed549d8853ef079c109..52f1781ce8d4115a4af0a231d58bb2f153923300 100644
--- a/text-viewer/src/main.c
+++ b/text-viewer/src/main.c
@@ -11,7 +11,10 @@
 #include "text_viewer.h"
 
 typedef enum {
-  SUCCESS,
+  ERROR_SUCCESS,
+  ERROR_NOT_ENOUGH_ARGUMENTS,
+  ERROR_CANT_OPEN_FILE,
+  ERROR_PHERIPHERALS,
 } error_t;
 
 int main(int argc, char *argv[]) {
@@ -40,6 +43,7 @@ int main(int argc, char *argv[]) {
   if (argc < 2) {
     logger_info(&logger, __FILE__, __FUNCTION__, __LINE__, "Not enough arguments");
     rgb_led_set_red(&rgb_leds, LED_LEFT);
+    return ERROR_NOT_ENOUGH_ARGUMENTS;
   }
 
   display_t display = mzapo_create_display();
@@ -49,6 +53,7 @@ int main(int argc, char *argv[]) {
   if (!mzapo_check_pheripherals(&ledstrip, &rgb_leds, &display, &knobs)) {
     logger_error(&logger, __FILE__, __FUNCTION__, __LINE__, "Could not initialize some of the pheripherals.");
     rgb_led_set_red(&rgb_leds, LED_LEFT);
+    return ERROR_PHERIPHERALS;
   }
 
   mzapo_pheripherals_t pheripherals = mzapo_pheripherals_create(&ledstrip, &rgb_leds, &display, &knobs);
@@ -63,8 +68,8 @@ int main(int argc, char *argv[]) {
   file_error_t error = text_viewer_load_file(&text_viewer);
   if (error != FILER_SUCCESS) {
     logger_error(&logger, __FILE__, __FUNCTION__, __LINE__, "Could not load file.");
-    return 1;
     rgb_led_set_red(&rgb_leds, LED_RIGHT);
+    return ERROR_CANT_OPEN_FILE;
   }
 
   file_set_nonblocking(STDIN_FILENO, &oldstdin);
@@ -84,5 +89,5 @@ int main(int argc, char *argv[]) {
   logger_info(&logger, __FILE__, __FUNCTION__, __LINE__,
               "Application quit");
 
-  return SUCCESS;
+  return ERROR_SUCCESS;
 }